MCP server for Zoom #56
Conversation
src/servers/zoom/README.md
Outdated
|
|
||
| ```json | ||
| { | ||
| "web": { |
There was a problem hiding this comment.
Why do we have this web key and why are we asking the user to specify the auth uri and token uri?
We don't do this for other other OAuth apps with the exception of Google that provides the json -- we just ask them to use the client id, client secret, redirect uri. We should stick to the same here unless there is a good reason
src/servers/zoom/README.md
Outdated
|
|
||
| This server exposes the following tools for interacting with Zoom: | ||
|
|
||
| - `zoom_create_a_meeting` – Create a new Zoom meeting |
There was a problem hiding this comment.
Why do all these tools name start with zoom_? We don't follow that convention anywhere else
src/servers/zoom/README.md
Outdated
| #### Example: Creating a Meeting | ||
|
|
||
| ``` | ||
| call ZOOM_CREATE_A_MEETING --topic "Team Meeting" --start_time "2025-05-25T15:00:00Z" --duration 60 --agenda "Weekly team sync" |
There was a problem hiding this comment.
This example doesn't make sense, the user doesn't call this directly so why are we showing this here?
src/servers/zoom/README.md
Outdated
| You can launch the server for local development using: | ||
|
|
||
| ```bash | ||
| python -m mcp.main --server zoom-server |
There was a problem hiding this comment.
This is not how this works...
src/servers/zoom/README.md
Outdated
| #### Running Tests | ||
|
|
||
| ```bash | ||
| python -m pytest tests/servers/zoom/tests.py -v |
There was a problem hiding this comment.
This is NOT how running the tests work and we shouldn't even have that in this readme
src/utils/zoom/util.py
Outdated
|
|
||
|
|
||
| # Simple callback handler to capture the authorization code | ||
| class OAuthCallbackHandler(BaseHTTPRequestHandler): |
There was a problem hiding this comment.
Why are we doing this here again and not using Oauth utils?
PR for implementation of MCP server for Zoom