8000 [GMLP-3117] Apollo new tools and resources by dvlpjrs · Pull Request #139 · gumloop/guMCP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[GMLP-3117] Apollo new tools and resources #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dvlpjrs
Copy link
Collaborator
@dvlpjrs dvlpjrs commented May 12, 2025

Greptile Summary

This pull request expands Apollo server functionality by integrating new tools and resources for advanced user management, search, and sequence operations.

  • Updated /src/servers/apollo/config.yaml to include new user resources and additional search/sequence management tool definitions.
  • Extended /src/servers/apollo/main.py with new endpoints for people, organization, and sequence operations along with improved error handling and logging.
  • Updated /tests/servers/apollo/tests.py for comprehensive coverage, noting a potential inconsistency with 'Opportunity ID' in deal updates and brittle ID extraction via string splitting.
  • Be cautious of synchronous HTTP calls in async functions and logging sensitive data.

Copy link
Contributor
@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +385 to +392
response = await client.process_query(
f"Use the update_deal tool to update the deal with the following details: "
f"Opportunity ID: {deal_id}, "
f"Name: {test_deal_updated['name']}, "
f"Amount: {test_deal_updated['amount']}, "
f"Closed Date: {test_deal_updated['closed_date']}. "
"If successful, start your response with 'Deal updated successfully'."
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Usage of 'Opportunity ID' in test_update_deal seems inconsistent with other tests; confirm that the underlying API expects this parameter label.

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0