8000 Clone from empty repository throws incorrect error · Issue #85 · guyzmo/git-repo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clone from empty repository throws incorrect error #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pyhedgehog opened this issue Dec 22, 2016 · 1 comment · Fixed by #86
Closed

Clone from empty repository throws incorrect error #85

pyhedgehog opened this issue Dec 22, 2016 · 1 comment · Fixed by #86
Assignees
@guyzmo
Labels
bug

Comments

@pyhedgehog
Copy link
Contributor
pyhedgehog commented Dec 22, 2016 •
edited
Loading 
# git hub -v clone pyhedgehog/choco-packages
Cloning choco-packages…
Fatal error: name 'ResourceNotFoundError' is not defined
------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/git_repo/repo.py", line 348, in do_clone
    service.clone(self.user_name, self.repo_name, self.branch)
  File "/usr/lib/python3.4/site-packages/git_repo/services/service.py", line 237, in clone
    self.pull(remote, branch)
  File "/usr/lib/python3.4/site-packages/git_repo/services/service.py", line 208, in pull
    remote.pull(branch, progress=pb)
  File "/usr/lib/python3.4/site-packages/git/remote.py", line 771, in pull
    res = self._get_fetch_info_from_stderr(proc, progress)
  File "/usr/lib/python3.4/site-packages/git/remote.py", line 638, in _get_fetch_info_from_stderr
    proc.wait(stderr=stderr_text)
  File "/usr/lib/python3.4/site-packages/git/cmd.py", line 291, in wait
    raise GitCommandError(self.args, status, errstr)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git pull --progress -v github master
  stderr: 'fatal: Couldn't find remote ref master'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/git_repo/repo.py", line 544, in main
    return GitRepoRunner(args).run()
  File "/usr/lib/python3.4/site-packages/git_repo/kwargparse.py", line 68, in run
    return self._action_dict[frozenset(args)](self)
  File "/usr/lib/python3.4/site-packages/git_repo/repo.py", line 357, in do_clone
    raise ResourceNotFoundError(err.args[2].decode('utf-8')) from err
NameError: name 'ResourceNotFoundError' is not defined
@pyhedgehog pyhedgehog changed the title Clone from bare (empty) repository throws incorrect error Clone from non-existant repository throws incorrect error Dec 22, 2016
@pyhedgehog pyhedgehog changed the title Clone from non-existant repository throws incorrect error Clone from bare (empty) repository throws incorrect error Dec 22, 2016
@guyzmo guyzmo changed the title Clone from bare (empty) repository throws incorrect error Clone from empty repository throws incorrect error Dec 23, 2016
@guyzmo
Copy link
Owner
guyzmo commented Dec 23, 2016

👌 same kind of errors!
basically, it's only the exceptions that I forgot to import in the repo module.

guyzmo added a commit that referenced this issue Dec 23, 2016
@guyzmo
🚒 forgotten exception imports
d918faa 
fixes #85
fixes #84

Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
@guyzmo guyzmo mentioned this issue Dec 23, 2016
Merged
@guyzmo guyzmo self-assigned this Dec 23, 2016
guyzmo added a commit that referenced this issue Dec 28, 2016
@guyzmo
👍 Merge branch devel ; 🔖 Version bump to 1.8.0
ee6384d 
🚧 Features

* Support for insecure connection through config option (fixes #66)
* Made gitlab feature complete:
 * Added support for list command in gitlab (cf #78)
 * Added support for gitlab gists (fixes #12)
 * Added support for gitlab merge requests (fixes #10)

🚒 Bugfixes

* Bad exceptions handling mistakes (fixes #84, fixes #85)
* Missing edge case handling in list command (fixes #83)

💄 Cosmetics

* Updated README with new config option
* Added @rnestler to contributors
* Updated TODO list

Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyzmo guyzmo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/exceptions import forgotten guyzmo/git-repo
2 participants
@guyzmo @pyhedgehog
0