Changed the reason phrase casting from int to string #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int casting of reason phrase was converting legitimate string response header message to 0. e.g. If api send res `header("HTTP/1.1 401 Some message");` , "Some message" was resulted in 0 because of int casting and hence could not be fetched with `getReasonPhrase()` method. Instead default matching message from `$phrases` message map from `Response` class was returned.
…casting-patch-1 Changed the reason phrase casting from int to string
mtdowling
added a commit
that referenced
this pull request
Jul 28, 2015
Changed the reason phrase casting from int to string
|
Thanks! |
|
Pleasure! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int casting of reason phrase was converting legitimate string response header message to 0. e.g. If api send res
header("HTTP/1.1 401 Some message");, "Some message" was resulted in 0 because of int casting and hence could not be fetched withgetReasonPhrase()method. Instead default matching message from$phrasesmessage map fromResponseclass was returned. I looked in docs for reason behind int casting but could not find it.