8000 configurable font for text annotations by ri-char · Pull Request #68 · gabm/Satty · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

configurable font for text annotations #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2024
Merged

configurable font for text annotations #68

merged 3 commits into from
Mar 27, 2024

Conversation

ri-char
Copy link
Contributor
@ri-char ri-char commented Mar 25, 2024

It allows user to customize font for text annotations. Otherwise, Chinese Characters can not be rendered.

@gabm
Copy link
Owner
gabm commented Mar 25, 2024

thank you so much for this contribution, I appreciate your effort...

But it makes me wonder whether it would make sense to leverage fontconfig instead? that would be more in line with other software: let the user specify a font family via the config and look it up via fontconfig.. and have a (packaged) fallback included...

Copy link
Owner
@gabm gabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution. I left some comments

@gabm gabm merged commit 591a920 into gabm:main Mar 27, 2024
@gabm
Copy link
Owner
gabm commented Mar 27, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0