make annotation_size_factor configurable from UI #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Revealing/hiding the elements now looks like this:
|
5ba3ad3 to
92f7858
Compare
|
dealing with the focus in a consistent way, considering tab, enter, potentially escape, cursor up/down and pgup/pgdown is trickier than I thought. Even using the hide button as a possible focus target doesn't make it much better. Either the text box of the spin button remains unfocusable, or this needs to go in a dialog. |
|
I think that's working better now. |
e582deb to
2223eb0
Compare
|
|
|
thanks, looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #106
(screenshot outdated, see #154 (comment))
annotation_size_factorconfig setting, using GTK SpinButton control. This affects the sizes of all tools and allows for finer control of the annotation sizes ;)The original goal of the issue was to make the font/font size configurable. I think somebody can implement that later, for now this seemed like a much quicker win.
TODO Items:
GTK_DEBUG=interactiveit has the same color as the others. Edit: it was "edit-reset" vs "edit-reset-symbolic"Also, I'm not really familiar with Relm. I couldn't say if all of this is the best possible way to implement it. It does work here and didn't seem to break anything. ;) I have tried adjusting the
APP_CONFIGwithwritebut that led to deadlocks (orWouldBlockwithtry_write) -- since nothing else writes except for intially command line parameters and config, this might not have been the way to go anyway.