add alt modifier to ellipse tool #165
Conversation
This allows dragging circle from corner. Ctrl+shift draws a circle from corner.
|
looks great, that was a comment on reddit yesterday :) I have two questions
|
|
Re 1: yeah, I thought I might have to rework that. 😄 I only have access to powerpoint online.
Perhaps I can think of more other apps to check and we might see inconsistencies between alt and ctrl, but it kinda looks like "from corner" should be the default behaviour. Re 2: since I'm storing the origin in the ellipse, I can start over with whatever the mode is in that very moment. E.g. start with ctrl, it draws "from corner", let go of ctrl, the circle is now drawn "from center" starting with the original origin. That behaviour matches Excalidraw and Gimp. |
|
i don't think we need to check all the other tools.. from corner as default and shift for "circle" are default imho. Let's go with alt for center and that's it?! |
Also move calculate shape and add some helper indicators
|
That's changed now, using none for "from corner" and alt for "from circle". According to google, Photoshop also seems to use Alt. I've added some helper indicators:
Felt like a nice addition and helps proving the math isn't terribly bad, but I can take it out again if it's too much. (Would have been nice to use a dashed line, but that seems overly complicated with femtovg). The hardcoding (color/paint width) isn't ideal, but can be revisited if we ever touch other tools. |
|
that looks great, thanks so much! |
Closes #125
This allows dragging circle from corner.
Ctrl+shift draws a circle from corner.
I suppose we could think about swapping around control and not control.