8000 fix: text: undo all not working for active text tool by RobertMueller2 · Pull Request #229 · gabm/Satty · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: text: undo all not working for active text tool #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2025
Merged

fix: text: undo all not working for active text tool #229

merged 1 commit into from
Jun 1, 2025

Conversation

RobertMueller2
Copy link
Collaborator

Closes #193

If text tool is currently active:

  • deactivate text tool so handle_reset doesn't get stuck with text tool's handle_undo
  • commit the result so the active text is available for redo

@RobertMueller2
fix: text: undo all not working for active text tool
b50aca8 
Closes gabm#193

If text tool is currently active:
- deactivate text tool so handle_reset doesn't get stuck with text
  tool's handle_undo
- commit the result so the active text is available for redo
@gabm gabm merged commit d56094d into gabm:main Jun 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabienjuif fabienjuif fabienjuif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undo/redo with text can break
3 participants
@RobertMueller2 @fabienjuif @gabm
0