Tags: gaf3/pipeline
Tags
Change the webhook name to pipeline-webhook The "webhook" name is too generic and it creates conflicts on leases when other services (like triggers) that use leader election run in same namespace but with different configuration. Fixes tektoncd#3529 Co-authored-by: Matt Moore <mattmoor@vmware.com> Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com> (cherry picked from commit 747f4ba)
Avoid dangling symlinks in git-init When the following conditions are met: 1. the feature flag disable-home-env-overwrite is "true" 2. the container user is root 3. no git / ssh secret is attached to a taskrun service account 4. user is running new-ish version of catalog git-clone task with git-init v0.15.2+ git-init will error out in the git-clone task because we create a circular symlink from /root/.ssh to itself and then try to look up /root/.ssh/known_hosts. This commit adds a check to avoid this from happening: If the user's $HOME/.ssh directory doesn't exist or if they aren't able to access it for any reason, then we don't try to create a symlink to it at all since we can trust that the user is incapable of utilizing the credential. This commit also expands an existing check to see if the $HOME/.ssh directory is the same as the user's home directory + '.ssh'. This was originally only checked if the user was nonroot, but now this is also checked if the user is root too. (cherry picked from commit 1160686) Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Take -version into account in the controller ☕️ Set the `version.PipelineVersion` properly in the controller main so that we annotate the object with the version (instead of a blank string). Signed-off-by: Vincent Demeester <vdemeest@redhat.com> (cherry picked from commit f59e1be) Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Add docs demonstrating how to share a Workspace with Sidecars Prior to this commit we didn't have any documentation showing how to share a Workspace between Steps of a Task and the Task's Sidecars. In fact there were 8258 two bugs that prevented this from working correctly. Those bugs have since been squashed. This commit adds documentation and an example yaml showing how to share a Workspace between a Task's Steps and its Sidecars.
Omit NotFound when cleaning up the Affinity Assistant The PipelineRun reconciler cleanup the affinity assistant when the PipelineRun is completed. If the cleanup-function is called more than once, the DELETE request will return a NotFound response. It does not make sense to return NotFound responses as an error, since this is what we want to achieve. (cherry picked from commit 204a403)
Disable keep-alive for cloud-event connections Disable keep alive forces the HTTP client to drop the connection once a response is received. This avoids building up large numbers of idle connections and it fixes the immediate issue. After this we may want to see how to ensure we can re-use connection and also set and idle-connection timeout. Fixes tektoncd#3190 (cherry picked from commit 7a9a85b)
PreviousNext