8000 Fix context lost bug by GuoLei1990 · Pull Request #2671 · galacean/engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix context lost bug #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 20, 2025
Merged

Fix context lost bug #2671

merged 5 commits into from
May 20, 2025

Conversation

GuoLei1990
Copy link
Member
@GuoLei1990 GuoLei1990 commented May 20, 2025 •
edited by coderabbitai bot
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • Bug Fixes
    • Improved framebuffer error checking to prevent errors when the WebGL context is lost.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 20, 2025 •
edited
Loading

Warning

Rate limit exceeded

@GuoLei1990 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6b9b9fa and 57be96b.

📒 Files selected for processing (1)
  • packages/rhi-webgl/src/GLRenderTarget.ts (1 hunks)

Walkthrough

A guard condition was added to the _checkFrameBuffer method to ensure framebuffer error checking only occurs if the framebuffer is incomplete and the WebGL context is not lost. The handling for various framebuffer error statuses remains unchanged, but is now gated by this new conditional logic.

Changes

File(s) Change Summary
packages/rhi-webgl/src/GLRenderTarget.ts Modified _checkFrameBuffer to add a guard condition for error checking based on framebuffer status and context loss, and simplified WebGL2 multisample status handling.

Poem

In the land of WebGL, a check now stands tall,
Only peeking for errors if the context won't fall.
Framebuffers incomplete? We’ll catch you, beware!
But if context is lost, we simply won’t care.
A hop, a skip, and a bug fixed anew—
This rabbit’s delight is coding with you! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@GuoLei1990 GuoLei1990 self-assigned this May 20, 2025
@GuoLei1990 GuoLei1990 added bug Something isn't working resource Resource-related functions labels May 20, 2025
8000
@GuoLei1990 GuoLei1990 added this to the 1.5 milestone May 20, 2025
@codecov Codecov
Copy link
codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.95%. Comparing base (60b8d36) to head (57be96b).
Report is 4 commits behind head on dev/1.5.

Files with missing lines Patch % Lines
packages/rhi-webgl/src/GLRenderTarget.ts 22.22% 7 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/1.5    #2671      +/-   ##
===========================================
- Coverage    68.97%   68.95%   -0.03%     
===========================================
  Files          975      975              
  Lines       102785   102831      +46     
  Branches      8906     8905       -1     
===========================================
+ Hits         70895    70906      +11     
- Misses       31621    31656      +35     
  Partials       269      269
Flag Coverage Δ
unittests 68.95% <22.22%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cptbtptpbcptdtptp
cptbtptpbcptdtptp approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator
@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 4bc2469 into galacean:dev/1.5 May 20, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptbtptpbcptdtptp cptbtptpbcptdtptp cptbtptpbcptdtptp approved these changes

Assignees

@GuoLei1990 GuoLei1990

Labels
bug Something isn't working resource Resource-related functions
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@GuoLei1990 @cptbtptpbcptdtptp
0