-
Notifications
You must be signed in to change notification settings - Fork 218
Remove binlike from testing #5937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5937 +/- ##
==========================================
- Coverage 94.78% 94.77% -0.01%
==========================================
Files 239 239
Lines 38334 38335 +1
==========================================
- Hits 36334 36332 -2
- Misses 2000 2003 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
While this is true, it still might be the format that is used by fermipy. Not sure we have a separate test for this, would be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty ! I support the removal of binlike, because the stored values are confusing.
To ensure compatibility with what fermi provide (and I am not sure we are completely compatible now), we can add a new test file
Good idea, I've created an issue gammapy/gammapy-data#74 for that. For this PR we can keep it as is |
3834fa4
to
de910fd
Compare
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
This is part of the cleanup over on gammapy/gammapy-data#41