8000 Remove binlike from testing by Astro-Kirsty · Pull Request #5937 · gammapy/gammapy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove binlike from testing #5937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Astro-Kirsty
Copy link
Member

This is part of the cleanup over on gammapy/gammapy-data#41

Copy link
codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (6fb7d92) to head (3834fa4).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5937      +/-   ##
==========================================
- Coverage   94.78%   94.77%   -0.01%     
==========================================
  Files         239      239              
  Lines       38334    38335       +1     
==========================================
- Hits        36334    36332       -2     
- Misses       2000     2003       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adonath
Copy link
Member
adonath commented Jun 20, 2025

The stat_scan values in tests/spectrum/flux_points/binlike.fits are not compatible with the results. Remove?

While this is true, it still might be the format that is used by fermipy. Not sure we have a separate test for this, would be good.

Copy link
Member
@AtreyeeS AtreyeeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Astro-Kirsty ! I support the removal of binlike, because the stored values are confusing.
To ensure compatibility with what fermi provide (and I am not sure we are completely compatible now), we can add a new test file

@Astro-Kirsty
Copy link
Member Author

Good idea, I've created an issue gammapy/gammapy-data#74 for that. For this PR we can keep it as is

Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0