Fix all byte-compiler warnings in gambit.el. Fix a docstring. #710
Conversation
- Moved defvar before their use.
- Add forward declaration defvar.
- Replace deprecated or interactive functions/macros by appropriate ones.
- Declare XEmacs functions when in XEmacs but prevents warnings in Emacs.
- No change in behaviour.
- Moved defvar before their use. - Add forward declaration defvar. - Replace deprecated or interactive functions/macros by appropriate ones. - Declare XEmacs functions when in XEmacs but prevents warnings in Emacs. - No change in behaviour.
|
I'm happy to help submit this into MELPA. Have you looked at geiser-gambit, and does |
|
@lassik Hi! I'm quite new to Gambit so I can't answer your question. I was going to look into geiser-gambit but I have not done it yet. What I'm doing is integrating support for several languages into my system PEL and I was also going to start looking for adding iMenu support for Gambit as well as some others like Gerbil. I can't object to support to MELPA (and would be glad if someone did it), but I personally do not need it (for files not turned into elpa package my system copies them in a directory that is in my load-path). |
|
Also I should have mentioned that I did not provide backward compatibility to old versions of Emacs that do not support:
I assumed these are old enough so changing the code would not cause problems. |
|
I am also planning to replace the user definable defvar by customizable defcustom in a gambit defgroup. |
- Replaced user overridable defvar by defcustom forms.
- The defgroup is 'gambit, a child of 'scheme group.
- Have not replaced gambit-highlight-color defvar by a defface
because I'm not familiar enough with overlays at the moment.
- I left a TODO note; using defface would be much more flexible
allowing users select other face properties and select colors
through a color menu.
No objection from me. |
|
I'm not an elisp expert, so I don't know what that means... but if it works with "old" (~5 years ago) releases of emacs I'm ok with it. |