8000 feat(Rust): Add integer type inference option by jonashao · Pull Request #2 · gamkay/quicktype · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(Rust): Add integer type inference option #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(Rust): Add integer type inference option #2

wants to merge 1 commit into from

Conversation

jonashao
Copy link
Collaborator

Description

This PR introduces integer type inference for Rust targets, providing better control over generated integer types (i32/i64):

  1. Added IntegerType enum with variants:

    • conservative: Selects i32/i64 based on JSON sample ranges
    • force-i32: Always uses i32 (caution: risk of overflow)
    • force-i64: Default behavior (current output)

  2. Added integerType configuration option for CLI and programmatic interfaces:

    quicktype --integer-type conservative  # Smart selection (default)
quicktype --integer-type force-i32

Related Issue

glideapps#2790
(Original feature request: glideapps#2790)

Motivation and Context

  • ⚠️ Problem: Current behavior always generates i64 even when values fit in i32, causing:
    • Memory bloat (4-byte vs 8-byte overhead)
    • Compatibility issues with Rust libraries expecting i32
    • Serialization/deserialization performance penalties
  • ✅ Solution: Gives users control to optimize for:
    • Memory efficiency (force-i32)
    • Safety (force-i64)
    • Smart balancing (conservative)

Previous Behaviour / Output

All integers unconditionally became i64:

// JSON schema input:  {"id": {"type": "integer","minimum": 0, "maximum": 100}}
pub struct Data {
    pub id: i64,  // ← Always i64 even for small values
}

New Behaviour / Output

With --integer-type conservative:

// JSON schema input: {"id": {"type": "integer","minimum": 0, "maximum": 100}, "big": {"type": "integer","minimum": 0, "maximum": 9223372036854775807}}
pub struct Data {
    pub id: i32,   // ← conservative-downgraded to i32
    pub big: i64,  // ← Remains i64 for large values
}

How Has This Been Tested?

  1. Unit Tests:

    • Added integer-type.schema test input and rust langauge quickTestRendererOptions:
      • Range detection logic (conservative mode)
      • Forced type behaviors (force-i32/force-i64)
    • Integration tests for CLI flag parsing

  2. Validation Tests:

    # Tested with sample datasets:
script/quicktype -s schema test/inputs/schema/integer-type.schema -o out.rs 
script/quicktype -s schema test/inputs/schema/integer-type.schema -o out.rs  --integer-type force-i32
script/quicktype -s schema test/inputs/schema/integer-type.schema -o out.rs  --integer-type force-i64
    • Verified output compiles with cargo check

  3. Environment:

    • Rust 1.87 + TypeScript 5.0
    • Windows/Linux/macOS cross-validation

@jonashao
feat(Rust): Add integer type inference option
d794381 
1. Added IntegerType enum
2. Introduced integerType configuration option
 - Supports forced i32/i64 usage
 - Enables automatic selection based on numerical range
@jonashao jonashao closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonashao
0