Fix macOS drag #891
Merged
Fix macOS drag #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, on macOS, the drag-end signal no longer can query for things like the starting position. Until this issue is fixed, we can store the starting position ourselves.
2e5c548 to
3406883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In Gaphor sometimes, especially on macOS, the moved items jump back to their original place when. This may be because by the time the
Gesture::endsignal is triggered, the sequence is no longer valid.The
Gtk.Gesture::endhandler (which emitsGtk.GestureDrag::drag-end) doesn't check if the sequence is handled by the gesture, whileGtk.GestureDrag.get_start_point()does. Hence, we do get an offset, but we cannot obtain the start position from the sequence anymore.Issue Number: Fixes gaphor/gaphor#3753
What is the new behavior?
We store the start position ourselves. This way we do no longer need to rely on the event sequence still being active when ending a drag operation.
Does this PR introduce a breaking change?
Other information
It may be nicer to rewrite the move handlers to work with offsets, so the interface is in line with what we have in the controllers. However, that's considerably more work.