8000 Added a file containing shoot identifier to safe guard against wrong volume mount. by abdasgupta · Pull Request #468 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added a file containing shoot identifier to safe guard against wrong volume mount. #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

Added a file containing shoot identifier to safe guard against wrong volume mount. #468

merged 1 commit into from
Apr 25, 2022

Conversation

abdasgupta
Copy link
Contributor
@abdasgupta abdasgupta commented Apr 20, 2022 •
edited
Loading

What this PR does / why we need it:
This PR checks whether wrong volume is mounted to ETCD container and if so, it doesn't start the ETCD. It writes shoot identifier to a file in the mounted volume. Then it checks if the mounted volume contains file with the same shoot identifier that is passed to it as POD Namespace.

Which issue(s) this PR fixes:
Fixes #
#466

Special notes for your reviewer:

Release note:

- ETCD won't restart from the PVC if it is wrongly mounted to the pod

@abdasgupta abdasgupta requested a review from a team as a code owner April 20, 2022 10:38
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Apr 20, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 20, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 20, 2022
dguendisch
dguendisch previously requested changes Apr 20, 2022
View reviewed changes
Copy link
Member
@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Only two nits, rest lgtm (although I cannot really test this locally, so I hope an etcd-br maintainer will review as well)

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Apr 20, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 21, 2022
dguendisch
dguendisch reviewed Apr 21, 2022
View reviewed changes
Copy link
Member
@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aaronfern aaronfern self-assigned this Apr 21, 2022
aaronfern
aaronfern approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor
@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it's working as expected.

/lgtm

@ishan16696
Copy link
Member
ishan16696 commented Apr 21, 2022 •
edited
Loading

Can you please add a release note as well @abdasgupta.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 25, 2022
@abdasgupta abdasgupta merged commit 2c40667 into gardener:master Apr 25, 2022
@abdasgupta abdasgupta deleted the safeguard branch April 25, 2022 08:21
@ishan16696 ishan16696 mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch left review comments

@aaronfern aaronfern aaronfern approved these changes

Assignees

@vlerenc vlerenc

@vpnachev vpnachev

@dguendisch dguendisch

@aaronfern aaronfern

Labels
needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@abdasgupta @ishan16696 @dguendisch @aaronfern @vlerenc @vpnachev @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0