Build Multi-Arch Images 📦 #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8689452 to
ce6874d
Compare
29 tasks
0fe7d3b to
eebf9ea
Compare
eebf9ea to
ce6874d
Compare
shreyas-s-rao
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
@timuthy Thanks for the PR! Overall LGTM, along with a suggestion. PTAL
| @@ -50,23 +50,9 @@ VERSION_FILE="$(${READLINK_BIN} -f "${SOURCE_PATH}/VERSION")" | |||
| VERSION="$(cat "${VERSION_FILE}")" | |||
| GIT_SHA=$(git rev-parse --short HEAD || echo "GitNotFound") | |||
|
|
|||
| # If no LOCAL_BUILD environment variable is set, we configure the `go build` command | |||
| # to build for linux OS, amd64 architectures and without CGO enablement. | |||
| if [[ -z "$LOCAL_BUILD" ]]; then | |||
There was a problem hiding this comment.
Since we're removing the check for LOCAL_BUILD env var, do we remove the make build-local target as well? Since both the targets essentially run the same go build command now. Or do we still retain that for legacy purposes and remove it later?
There was a problem hiding this comment.
I'd vote for leaving make build-local as is for legacy purposes and removing it in the next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR lets the CI pipeline build multi-arch images including
linux/amd64andlinux/arm64images.Which issue(s) this PR fixes:
Fixes partly #gardener/gardener#6258
Release note: