Don't update peer URL when promoting member #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign |
timuthy
suggested changes
Jul 21, 2022
|
Thanks for the review @timuthy! |
timuthy
approved these changes
Jul 21, 2022
aaronfern
added a commit
to aaronfern/etcd-backup-restore
that referenced
this pull request
Jul 21, 2022
* Don't update peer URL when promoting member * Update interface name in member package
aaronfern
added a commit
that referenced
this pull request
Jul 21, 2022
* Added support to run etcd client calls only when in multi-node case (#504) * Added support to run etcd client calls only when in multi-node case * Addressed review comments * Used values from restoreOpts rather than another func call * Temp fix: skip single member restoration in case of data-dir invalid. (#501) * Temp fix: skip single member restoration in case of data-dir invalid. * Small fixes. * Improved error log. * Fixed a bug in scaleup feature which present in func: IsMemberInCluster. * Fix the unit tests. * Address the review comments. * Handle the case of when storageProvider is not configured. * Address the review comments. * Address the review comments. * Assigned the correct Peer Address to Etcd after it restores from the backup-bucket. (#505) * Assigned the correct Peer address to the Etcd after restoration. * Fix the unit tests and some refactoring. * Improve some logs. * Address the review comments. * To update the peer address of existing cluster. * Don't update peer URL when promoting member (#506) * Don't update peer URL when promoting member * Update interface name in member package Co-authored-by: Ishan Tyagi <42602577+ishan16696@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates member promote logic to not attempt to update peer URL while promoting a member.
Promote member is called only when in multi node case and in that case updated member peer URLs are already used since these are new nodes/pods trying to join the cluster
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: