8000 Adds a feature of single member restoration in multi-node etcd. by ishan16696 · Pull Request #509 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds a feature of single member restoration in multi-node etcd. #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 4, 2022
Merged

Adds a feature of single member restoration in multi-node etcd. #509

merged 9 commits into from
Aug 4, 2022

Conversation

ishan16696
Copy link
Member
@ishan16696 ishan16696 commented Jul 26, 2022 •
edited
Loading

What this PR does / why we need it:
This PR adds a feature for restoration of single member in mult-node etcd cluster in case of data/data-dir of etcd member found to be corrupt/invalid.

Which issue(s) this PR fixes:
Fixes gardener/etcd-druid#368

Special notes for your reviewer:
Design Doc PR: gardener/etcd-druid#376

Release note:

For multi-node etcd: Added a feature of single member etcd restoration in case of data/data-dir of etcd member found to be corrupted or invalid.

@ishan16696 ishan16696 requested a review from a team as a code owner July 26, 2022 05:48
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 26, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 26, 2022
@ishan16696
Copy link
Member Author
ishan16696 commented Jul 26, 2022 •
edited
Loading

Please note: etcd-events case(when no snapstore is configured) is still needs to be handled.
/do-not-merge

Update:
edit: case when no snapstore is configured is now handled.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 26, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 27, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 27, 2022
@ishan16696
Added a feature of single member restoration in multi-node etcd when …
9416586 
…snapstore is not configured.
@ishan16696 ishan16696 force-pushed the restore-SingleMember branch from b6309d7 to 9416586 Compare July 27, 2022 06:40
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 27, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 27, 2022
@ishan16696 ishan16696 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 27, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 27, 2022
@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 27, 2022
aaronfern
aaronfern requested changes Jul 27, 2022
View reviewed changes
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jul 27, 2022
@ishan16696 ishan16696 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 27, 2022
shreyas-s-rao
shreyas-s-rao requested changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator
@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishan16696 Thanks for the well-written PR. I have added a few questions/suggestions in my review. Can you please address them? Thanks.

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2022
@ishan16696 ishan16696 force-pushed the restore-SingleMember branch from 75b29a5 to 92220c2 Compare July 28, 2022 05:51
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 29, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 1, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 1, 2022
@timuthy timuthy added this to the v0.19.0 milestone Aug 2, 2022
@aaronfern aaronfern added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2022
aaronfern
aaronfern requested changes Aug 3, 2022
View reviewed changes
Copy link
Contributor
@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good from my pov
I've also tested it out and it's working fine

Just a few last minute changes :)

8000
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 3, 2022
@ishan16696 ishan16696 force-pushed the restore-SingleMember branch from 85d5e65 to 86dcb96 Compare August 4, 2022 05:46
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2022
aaronfern
aaronfern approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor
@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my pov, thank you :)
/lgtm

67E6
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 4, 2022
@ishan16696
Copy link
Member Author

/ping @shreyas-s-rao

@gardener-robot
Copy link

@shreyas-s-rao

Message

/ping @shreyas-s-rao

shreyas-s-rao
shreyas-s-rao approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator
@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes.
/lgtm

@ishan16696 ishan16696 merged commit 81f517b into gardener:master Aug 4, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 4, 2022
@ishan16696 ishan16696 mentioned this pull request Aug 4, 2022
Closed
2 tasks
@ishan16696 ishan16696 deleted the restore-SingleMember branch August 4, 2022 10:08
This was referenced Aug 16, 2022
Closed
Closed
@ashwani2k ashwani2k mentioned this pull request Sep 20, 2022
Closed
@ishan16696 ishan16696 mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall left review comments

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@aaronfern aaronfern aaronfern approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.

[Feature]Restore a ETCD member when data directory / PVC is corrupted
9 participants
@ishan16696 @gardener-robot @unmarshall @shreyas-s-rao @aaronfern @gardener-robot-ci-1 @timuthy @gardener-robot-ci-2 @gardener-robot-ci-3
0