8000 Added the new metrics needed to be exposed for multi-node etcd. by ishan16696 · Pull Request #522 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added the new metrics needed to be exposed for multi-node etcd. #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2022
Merged

Added the new metrics needed to be exposed for multi-node etcd. #522

merged 3 commits into from
Sep 2, 2022

Conversation

ishan16696
Copy link
Member
@ishan16696 ishan16696 commented Aug 26, 2022 •
edited
Loading

What this PR does / why we need it:
This PR adds new metrics which required to be exposed via backup-restore to get more information about multi-node etcd which will be helpful in debugging/fine-tuning the multi-node etcd.

Which issue(s) this PR fixes:
Fixes # gardener/etcd-druid#358

Special notes for your reviewer:
Please see gardener/etcd-druid#414

Release note:

Added new metrics for multi-node etcd: `etcdbr_defragmentation_duration_seconds`, `etcdbr_restoration_duration_seconds` , `etcdbr_cluster_size` , `etcdbr_is_learner `, `etcdbr_is_learner_count_total `, `etcdbr_add_learner_duration_seconds `, `etcdbr_member_remove_duration_seconds `, `etcdbr_member_promote_duration_seconds `.

@ishan16696 ishan16696 requested a review from a team as a code owner August 26, 2022 04:59
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 26, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 26, 2022
@ishan16696
Copy link
Member Author
ishan16696 commented Aug 26, 2022 •
edited
Loading

FYI. new metric: etcdbr_defragmentation_duration_seconds in multi-node etcd right now might not work as expected.
I will verify it again.
/do-not-merge

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 26, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 26, 2022
@ishan16696
Copy link
Member Author

FYI. new metric: etcdbr_defragmentation_duration_seconds in multi-node etcd right now might not work as expected.
I will verify it again.

It is working fine

@ishan16696 ishan16696 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 26, 2022
aaronfern
aaronfern requested changes Aug 26, 2022
View reviewed changes
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Aug 26, 2022
shreyas-s-rao
shreyas-s-rao requested changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator
@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishan16696 thanks for the much-needed PR. I have some suggestions. PTAL, thanks.

@ishan16696 ishan16696 mentioned this pull request Aug 30, 2022
Merged
aaronfern
aaronfern requested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor
@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had another look. In general seems fine and also working fine so far

Just a couple of comments

@ishan16696
Copy link
Member Author
ishan16696 commented Sep 1, 2022 •
edited
Loading

I have introduced new metrics etcdbr_is_learner_count_total and removed this metrics: HasLearner as it overlapped with IsLearner . PTAL

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2022
aaronfern
aaronfern approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor
@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @ishan16696!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 2, 2022
@ishan16696
Copy link
Member Author

Pipeline is having some issues ... I will re-push again.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 2, 2022
shreyas-s-rao
shreyas-s-rao approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator
@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishan16696 Thanks for making the requested changes.
/lgtm

@ishan16696 ishan16696 merged commit 30abf47 into gardener:master Sep 2, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 2, 2022
@ishan16696 ishan16696 deleted the exposeMetricsForMN branch September 2, 2022 08:26
@ishan16696 ishan16696 mentioned this pull request Sep 2, 2022
Closed
@shreyas-s-rao shreyas-s-rao mentioned this pull request Nov 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@aaronfern aaronfern Awaiting requested review from aaronfern

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ishan16696 @shreyas-s-rao @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0