8000 Fix the `probeEtcd func()` to probe the corresponding Etcd by ishan16696 · Pull Request #523 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the probeEtcd func() to probe the corresponding Etcd #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2022
Merged

Fix the probeEtcd func() to probe the corresponding Etcd #523

merged 2 commits into from
Sep 2, 2022

Conversation

ishan16696
Copy link
Member
@ishan16696 ishan16696 commented Aug 31, 2022 •
edited
Loading

What this PR does / why we need it:
We have observed that probeEtcd is just getting the foo key inorder to probe the Etcd. This PR fixes the probeEtcd func() to probe the corresponding Etcd in better way by getting its Endpoint Status.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix the `probeEtcd func()` to probe the corresponding Etcd by getting its Endpoint Status rather than just `Get` a key.

@ishan16696 ishan16696 requested a review from a team as a code owner August 31, 2022 18:53
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 31, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2022
timuthy
timuthy suggested changes Sep 1, 2022
View reviewed changes
Copy link
Member
@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fixes 🚀
Can you please communicate in the release notes what issues those changes generally fix, so the community gets an idea why the fixes are so important?

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 1, 2022
@ishan16696
Close the snapshotter in better way.
819a68e 
Improve the probeEtcd func call.
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2022
@ishan16696
Copy link
Member Author

Can you please communicate in the release notes what issues those changes generally fix, so the community gets an idea why the fixes are so important?

done.

aaronfern
aaronfern approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor
@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ishan16696!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 1, 2022
@ishan16696
Copy link
Member Author

Integration tests are not working properly after adding this line.
I will try to fix else I will revert this change.

@ishan16696 ishan16696 changed the title Various bugFixes Fix the probeEtcd func() to probe the corresponding Etcd Sep 1, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2022
@ishan16696
Copy link
Member Author
ishan16696 commented Sep 1, 2022 •
edited
Loading

I have revert the commit: closing the snapshotter as integration tests not running fine, I don't know reason it may be due to flakiness of tests or any other reason, but let's not add something in haste.
I will pick this issue later.

cc @timuthy @aaronfern

aaronfern
aaronfern approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor
@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ishan16696 ishan16696 merged commit 4343a98 into gardener:master Sep 2, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 2, 2022
@ishan16696 ishan16696 deleted the fixSnapshotterBug branch September 13, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy approved these changes

@aaronfern aaronfern aaronfern approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ishan16696 @timuthy @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0