8000 Update to golang 1.18.6 by aaronfern · Pull Request #535 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update to golang 1.18.6 #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2022
Merged

Update to golang 1.18.6 #535

merged 2 commits into from
Sep 16, 2022

Conversation

aaronfern
Copy link
Contributor
@aaronfern aaronfern commented Sep 14, 2022 •
edited by ishan16696
Loading

What this PR does / why we need it:
This PR updated the golang version used to build images from 1.18.3 to 1.18.6
This PR also updated the pipeline definitions to use go 1.18.6

Which issue(s) this PR fixes:
Fixes CVE-2022-27664

Special notes for your reviewer:

Release note:

Updated golang version used to build images to 1.18.6

Updated golang version to 1.18

@aaronfern aaronfern requested a review from a team as a code owner September 14, 2022 13:00
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 14, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 15, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 15, 2022
@ishan16696
Copy link
Member
ishan16696 commented Sep 16, 2022 •
edited
Loading

In druid we have updated the golang version to 1.18.5 for both pipeline as well as to build images.
I would suggest can we have a cosistent golang version in pipeline as well as to build images for druid as well as for backup-restore, so that it is easy to track.

@aaronfern
Copy link
Contributor Author

We need golang 1.18.6 here to solve this vulnerability
I will open a separate PR on etcd-druid to update the golang version used there to 1.18.6

@ishan16696
Copy link
Member

ok, make sense

ishan16696
ishan16696 requested changes Sep 16, 2022
View reviewed changes
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 16, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 16, 2022
@aaronfern aaronfern changed the title Update to golang 1.18 Update to golang 1.18.6 Sep 16, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 16, 2022
@aaronfern aaronfern merged commit ab224ee into gardener:master Sep 16, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 16, 2022
aaronfern added a commit to aaronfern/etcd-backup-restore that referenced this pull request Sep 16, 2022
@aaronfern
Update to golang 1.18.6 (gardener#535)
39816ed 
* Update Dockerfile to use go 1.18.6

* Update pipeline definition to use go 1.18.6
@aaronfern aaronfern mentioned this pull request Sep 16, 2022
Merged
aaronfern added a commit that referenced this pull request Sep 16, 2022
@aaronfern @ishan16696 @unmarshall
Cherry pick commits for branch rel-v0.20 (#536)
0893f64 
* Fix the ProbeEtcd timeout. (#532)

* Fix the ProbeEtcd timeout.

* Improved th
7E64
e logging while closing the snapshotter.

* always update member peer url and changed the way to identify scaleup

* fixed unit tests

* addressed review comments

* addressed review comments

* used Errorf instead of Error

* made some modifications on how to initialize peerURLTLSEnabled

* removed commented code

* addressed review comment - removed commented code

* Update to golang 1.18.6 (#535)

* Update Dockerfile to use go 1.18.6

* Update pipeline definition to use go 1.18.6

Co-authored-by: Ishan Tyagi <42602577+ishan16696@users.noreply.github.com>
Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronfern @ishan16696 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0