10000 Introduce `gosec` for Static Application Security Testing (SAST) by shreyas-s-rao · Pull Request #815 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Introduce gosec for Static Application Security Testing (SAST) #815

10000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 26, 2024
Merged

Introduce gosec for Static Application Security Testing (SAST) #815

merged 8 commits into from
Dec 26, 2024

Conversation

shreyas-s-rao
Copy link
Collaborator
@shreyas-s-rao shreyas-s-rao commented Dec 19, 2024 •
edited
Loading

/area security
/kind enhancement

What this PR does / why we need it:
Introduce gosec for Static Application Security Testing (SAST) for etcd-backup-restore.

Which issue(s) this PR fixes:
Fixes #812

Special notes for your reviewer:
/invite @ashwani2k @ishan16696

Release note:

Introduce `gosec` for Static Application Security Testing (SAST) via `make sast` and `make sast-report`.

@shreyas-s-rao shreyas-s-rao added this to the v0.33.0 milestone Dec 19, 2024
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner December 19, 2024 14:39
@gardener-robot gardener-robot added the needs/review Needs review label Dec 19, 2024
@gardener-robot gardener-robot added area/security Security related kind/enhancement Enhancement, improvement, extension size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Dec 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 19, 2024
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Dec 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 19, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 19, 2024
ishan16696
ishan16696 requested changes Dec 19, 2024
View reviewed changes
8000
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Dec 19, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 20, 2024
ishan16696
ishan16696 requested changes Dec 20, 2024
View reviewed changes
@shreyas-s-rao
Copy link
Collaborator Author

@ishan16696 thanks for your review. I have addressed them. PTAL

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 20, 2024
@ishan16696 ishan16696 self-assigned this Dec 23, 2024
ishan16696
ishan16696 reviewed Dec 26, 2024
View reviewed changes
Copy link
Member
@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. only 1 nit,

ishan16696
ishan16696 requested changes Dec 26, 2024
View reviewed changes
@shreyas-s-rao
Address review comments from @ishan16696 - correctly handle defer fun…
401a2c6 
…c errors in test/e2e/integration/utils.go
@shreyas-s-rao
Copy link
Collaborator Author

@ishan16696 thanks for your review. I've addressed your comments. PTAL.

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 26, 2024
ishan16696
ishan16696 reviewed Dec 26, 2024
View reviewed changes
@shreyas-s-rao shreyas-s-rao added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 26, 2024
ishan16696
ishan16696 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member
@ishan16696 ishan16696 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making all changes.
LGTM!!

@shreyas-s-rao shreyas-s-rao merged commit 2438610 into gardener:master Dec 26, 2024
9 checks passed
@shreyas-s-rao shreyas-s-rao deleted the gosec-sast branch December 26, 2024 07:36
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

@ashwani2k ashwani2k Awaiting requested review from ashwani2k

Assignees

@ishan16696 ishan16696

Labels
area/security Security related kind/enhancement Enhancement, improvement, extension needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.33.0
Development

Successfully merging this pull request may close these issues.

Introduce gosec for Static Application Security Testing (SAST) for etcd-backup-restore
6 participants
@shreyas-s-rao @ishan16696 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0