Clean up snapshot temp directory during initialization #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shreyas-s-rao Labels area/todo, kind/todo do not exist. |
|
@shreyas-s-rao please resolve the merge conflicts. |
d441c08 to
2fcbadd
Compare
|
@ishan16696 done. PTAL |
|
/assign |
ishan16696
reviewed
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security compliance
/kind task cleanup
What this PR does / why we need it:
Clean up snapshot temp directory during initialization, to ensure any previously created temp files for snapshot upload will be cleaned up, which helps in two ways (a) to remove unnecessary files which may not have been properly cleaned up in a previous run of etcdbr and (b) these older files might have old file permissions before umask of 0077 was set, which might violate DISA STIG standards, hence cleaning up these files is beneficial from a security perspective as well.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: