10000 [rel-v0.36] Fix regression in cleaning up snapshot temp directory during initialization by seshachalam-yv · Pull Request #876 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[rel-v0.36] Fix regression in cleaning up snapshot temp directory during initialization #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

[rel-v0.36] Fix regression in cleaning up snapshot temp directory during initialization #876

merged 1 commit into from
May 14, 2025

Conversation

seshachalam-yv
Copy link
Contributor

How to categorize this PR?

/area backup
/kind regression bug

What this PR does / why we need it:
Cherry-pick of #875

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix regression in cleanup of snapshot temporary directory.

@shreyas-s-rao @seshachalam-yv
Fix regression in cleaning up snapshot temp directory during initiali… 
…zation (gardener#875)

* Fix regression in cleaning up snapshot temp directory during initialization

* Add unit tests for `pkg/snapstore.GetSnapstore()`
@seshachalam-yv seshachalam-yv requested a review from a team as a code owner May 13, 2025 17:17
@gardener-robot gardener-robot added area/backup Backup related kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 13, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 13, 2025
shreyas-s-rao
shreyas-s-rao reviewed May 13, 2025
View reviewed changes
Copy link
Collaborator
@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 13, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 13, 2025
< 8000 /div>
Shreyas-s14
Shreyas-s14 requested changes May 13, 2025
View reviewed changes
Shreyas-s14
Shreyas-s14 approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor
@Shreyas-s14 Shreyas-s14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seshachalam-yv seshachalam-yv merged commit c8bf86d into gardener:rel-v0.36 May 14, 2025
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao 70D8 shreyas-s-rao approved these changes

@Shreyas-s14 Shreyas-s14 Shreyas-s14 approved these changes

Assignees
No one assigned
Labels
area/backup Backup related kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seshachalam-yv @shreyas-s-rao @Shreyas-s14 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0