8000 Fix regression for snapshot temp dir cleanup when no snapstore configured by shreyas-s-rao · Pull Request #881 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix regression for snapshot temp dir cleanup when no snapstore configured #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

Fix regression for snapshot temp dir cleanup when no snapstore configured #881

merged 1 commit into from
May 15, 2025

Conversation

shreyas-s-rao
Copy link
Collaborator

How to categorize this PR?

/area backup
/kind regression bug

What this PR does / why we need it:
Fix regression for snapshot temp dir cleanup when no snapstore configured, by checking for whether snapstoreConfig is configured before attempting to clean up the temporary directory.

Which issue(s) this PR fixes:
Fixes #880

Special notes for your reviewer:
/invite @anveshreddy18 @seshachalam-yv

Release note:

Fix regression for snapshot temp dir cleanup when no snapstore configured.

@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner May 15, 2025 11:39
@gardener-robot gardener-robot added the needs/review Needs review label May 15, 2025
@gardener-robot gardener-robot added area/backup Backup related kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 15, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 15, 2025
@seshachalam-yv
Copy link
Contributor
seshachalam-yv commented May 15, 2025 •
edited
Loading

Please add unit tests.

@shreyas-s-rao
Copy link
Collaborator Author

@seshachalam-yv this doesn't technically qualify for unit tests. This behavior would ideally be tested in druid e2e tests.

seshachalam-yv
seshachalam-yv approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor
@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 15, 2025
@seshachalam-yv seshachalam-yv merged commit 15c2e52 into gardener:master May 15, 2025
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 15, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 15, 2025
shreyas-s-rao added a commit to shreyas-s-rao/etcd-backup-restore that referenced this pull request May 15, 2025
@shreyas-s-rao
Fix regression for snapshot temp dir cleanup when no snapstore config…
c8918c6 
…ured (gardener#881)
@shreyas-s-rao shreyas-s-rao deleted the fix/file-perms-2 branch May 15, 2025 13:10
@shreyas-s-rao shreyas-s-rao mentioned this pull request May 15, 2025
Merged
seshachalam-yv pushed a commit that referenced this pull request May 15, 2025
@shreyas-s-rao
Fix regression for snapshot temp dir cleanup when no snapstore config…
aec4ec0 
…ured (#881) (#882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anveshreddy18 anveshreddy18 anveshreddy18 approved these changes

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees
No one assigned
Labels
area/backup Backup related kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error when etcdbr is run with Druid without backups enabled
6 participants
@shreyas-s-rao @seshachalam-yv @anveshreddy18 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0