8000 Fix liveness probe command in helm chart by shreyas-s-rao · Pull Request #172 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix liveness probe command in helm chart #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2019
Merged

Fix liveness probe command in helm chart #172

merged 2 commits into from
Jul 2, 2019

Conversation

shreyas-s-rao
Copy link
Collaborator

What this PR does / why we need it:
This PR fixes the liveness probe command in the helm chart, which previously used to pass an illegal --config-file flag to the etcdctl command.
The PR also brings all port numbers in the helm chart into the values.yaml file.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed liveness probe command in helm chart.

@shreyas-s-rao
Move port numbers to values.yaml in helm chart
669e7b3 
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@shreyas-s-rao shreyas-s-rao added kind/bug Bug kind/enhancement Enhancement, improvement, extension area/quality Output qualification (tests, checks, scans, automation in general, etc.) related needs/review Needs review component/etcd-backup-restore ETCD Backup & Restore platform/all needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 2, 2019
@shreyas-s-rao shreyas-s-rao added this to the 1906b milestone Jul 2, 2019
@shreyas-s-rao shreyas-s-rao requested a review from swapnilgm July 2, 2019 09:35
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 2, 2019
@shreyas-s-rao
Fix etcd liveness probe command
6ce1673 
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@shreyas-s-rao shreyas-s-rao force-pushed the fix/liveness-probe-command branch from 92c74f7 to 6ce1673 Compare July 2, 2019 09:50
swapnilgm
swapnilgm approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor
@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
8000

@swapnilgm swapnilgm added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 2, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 2, 2019
@swapnilgm swapnilgm merged commit f985b5f into gardener:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilgm swapnilgm swapnilgm approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/etcd-backup-restore ETCD Backup & Restore kind/bug Bug kind/enhancement Enhancement, improvement, extension needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/all
Projects
None yet
Milestone
1906b
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyas-s-rao @swapnilgm @gardener-robot-ci-1
317E
0