8000 Add documentation for restoration by shreyas-s-rao · Pull Request #188 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add documentation for restoration #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2019
Merged

Add documentation for restoration #188

merged 1 commit into from
Aug 22, 2019

Conversation

shreyas-s-rao
Copy link
Collaborator

Signed-off-by: Shreyas Rao shreyas.sriganesh.rao@sap.com

What this PR does / why we need it:
This PR adds documentation for the restoration process and workflow.

Which issue(s) this PR fixes:
Fixes #186

Special notes for your reviewer:

Release note:

Added documentation for restoration.

@shreyas-s-rao shreyas-s-rao added needs/review Needs review component/etcd-backup-restore ETCD Backup & Restore needs/lgtm Needs approval for merging area/documentation Documentation related labels Aug 16, 2019
@shreyas-s-rao shreyas-s-rao added this to the 0.8.0 milestone Aug 16, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2019
swapnilgm
swapnilgm suggested changes Aug 20, 2019
View reviewed changes
Copy link
Contributor
@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation. I have suggested some changes. Please address those.

@shreyas-s-rao
Add documentation for restoration
5371937 
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 21, 2019
@shreyas-s-rao
Copy link
Collaborator Author

@swapnilgm Thanks for your review. I've addressed the suggestions. PTAL.

swapnilgm
swapnilgm approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor
@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@swapnilgm swapnilgm merged commit a17f708 into gardener:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilgm swapnilgm swapnilgm approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

Assignees
No one assigned
Labels
area/documentation Documentation related component/etcd-backup-restore ETCD Backup & Restore needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Document how to restore from backups
3 participants
@shreyas-s-rao @swapnilgm @gardener-robot-ci-1
0