8000 Add snapstore bucket-related metrics by shreyas-s-rao · Pull Request #211 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add snapstore bucket-related metrics #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2020
Merged

Add snapstore bucket-related metrics #211

merged 1 commit into from
Apr 13, 2020

Conversation

shreyas-s-rao
Copy link
Collaborator

Signed-off-by: Shreyas Rao shreyas.sriganesh.rao@sap.com

What this PR does / why we need it:
This PR adds two new metrics etcdbr_snapstore_latest_deltas_total and etcdbr_snapstore_latest_deltas_revisions_total, which provide information about the delta snapshots since the latest full snapshot in the snapstore (object store bucket). We assume that etcd-backup-restore process is the only handler of snapshots in the respective snapstore bucket, in order to maintain integrity of these metrics.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add metrics `etcdbr_snapstore_latest_deltas_total` and `etcdbr_snapstore_latest_deltas_revisions_total` to provide information about the delta snapshots since the latest full snapshot in the snapstore.

@shreyas-s-rao shreyas-s-rao added area/monitoring Monitoring (including availability monitoring and alerting) related needs/review Needs review component/etcd-backup-restore ETCD Backup & Restore platform/all needs/lgtm Needs approval for merging area/backup Backup related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2020
@shreyas-s-rao shreyas-s-rao added this to the 0.9.0 milestone Mar 1, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2020
swapnilgm
swapnilgm suggested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor
@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First thing, isn't it possible to build query around existing exposed metrics to get both of these counts? I think prometheus supports enough expressions and function to build query. Please give it a try. If it works i don't think we need this PR.

Regarding current PR i have suggested correction please address them. And also please update the metrics doc

@shreyas-s-rao
Add snapstore bucket-related metrics
79983c0 
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 12, 2020
@shreyas-s-rao
Copy link
Collaborator Author

@swapnilgm Thanks for the review. I've addressed the comments. PTAL.

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 12, 2020
swapnilgm
swapnilgm approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor
@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swapnilgm swapnilgm merged commit 6e19dae into gardener:master Apr 13, 2020
@shreyas-s-rao shreyas-s-rao deleted the bucket-metrics branch April 13, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilgm swapnilgm swapnilgm approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

Assignees
No one assigned
Labels
area/backup Backup related area/monitoring Monitoring (including availability monitoring and alerting) related component/etcd-backup-restore ETCD Backup & Restore needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/all
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@shreyas-s-rao @swapnilgm @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3
0