8000 add Dell EMC ECS S3 snapstore by spiarh · Pull Request #254 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add Dell EMC ECS S3 snapstore #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

add Dell EMC ECS S3 snapstore #254

merged 1 commit into from
Aug 4, 2020

Conversation

spiarh
Copy link
Contributor
@spiarh spiarh commented Aug 3, 2020 •
edited by swapnilgm
Loading

Signed-off-by: lcavajani lcavajani@suse.com

What this PR does / why we need it:

This PRs adds Dell EMC ECS Snapstore for S3 protocol.

It is fully compatible with AWS-SDK S3 so I have reused the existing S3 snapstore.

Special notes for your reviewer:

Release note:

Add support for **Dell EMC ECS** object store with `S3` protocol

@gardener-robot
Copy link

@lcavajani Thank you for your contribution.

@CLAassistant
Copy link
CLAassistant commented Aug 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot-ci-2
Copy link
Contributor

Thank you @lcavajani for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

swapnilgm
swapnilgm suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor
@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Nice to see that you could implement it without any help. Good work reusing S3 snapstore. I have suggested the couple of minor changes. PTAL.

swapnilgm
swapnilgm reviewed Aug 4, 2020
View reviewed changes
swapnilgm
swapnilgm reviewed Aug 4, 2020
View reviewed changes
@spiarh
Copy link
Contributor Author
spiarh commented Aug 4, 2020

Thanks for the review @swapnilgm !

I've updated the PR with the changes.

swapnilgm
swapnilgm approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor
@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/reviewed/ok-to-test
Yet, to test with actual ecs instance.
/hold

@gardener-robot gardener-robot added reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2020
add Dell EMC ECS S3 snapstore
8d24345 
Signed-off-by: lcavajani <lcavajani@suse.com>
@spiarh
Copy link
Contributor Author
spiarh commented Aug 4, 2020

@swapnilgm I've pushed a small change which makes the use of http proxy usable.

swapnilgm
swapnilgm approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor
@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction.
/lgtm
/reviewed/ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 4, 2020
@swapnilgm
Copy link
Contributor

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 4, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 4, 2020
@swapnilgm swapnilgm merged commit 221ac64 into gardener:master Aug 4, 2020
@shreyas-s-rao shreyas-s-rao mentioned this pull request Aug 13, 2020
Closed
@ishan16696 ishan16696 mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilgm swapnilgm swapnilgm approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

@shreyas-s-rao shreyas-s-rao Awaiting requested review from shreyas-s-rao

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spiarh @gardener-robot @CLAassistant @gardener-robot-ci-2 @swapnilgm
0