Added support for compaction metrics in druid. #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-s-rao
requested changes
Apr 17, 2023
There was a problem hiding this comment.
@abdasgupta thanks for the PR. Please address my review comments and also add documentation about the metrics being exposed by druid, similar to https://github.com/gardener/etcd-druid/blob/master/docs/multinode-metrics.md, under docs/monitoring/compaction-metrics.md.
Please also edit the release note to
Druid now exposes metrics related to snapshot compaction, on default port 8080. Please expose the desired metrics port via the etcd-druid service to allow metrics to be scraped by a Prometheus instance.
aaronfern
reviewed
Apr 25, 2023
|
/hold until druid v0.18 is released |
|
/unhold |
ishan16696
requested changes
May 19, 2023
ishan16696
requested changes
May 24, 2023
ishan16696
approved these changes
May 25, 2023
This was referenced May 26, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area disaster-recovery
/kind technical-debt
What this PR does / why we need it:
This PR exposes metrics related to compaction job initiated by druid.
Which issue(s) this PR fixes:
Fixes #515
Special notes for your reviewer:
As per the issue description, this PR exposes metrices for number of successful jobs, number of failed jobs, time taken to complete last job, number of delta events compacted, but it does not expose CPU and Memory consumption by last successful job. Resource consumption is the gauge that can only be measured from inside the job. Druid doesn't have access to that.
Release note: