8000 Cherry-pick commits for release v0.18.0 by abdasgupta · Pull Request #602 · gardener/etcd-druid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cherry-pick commits for release v0.18.0 #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2023
Merged

Cherry-pick commits for release v0.18.0 #602

merged 2 commits into from
May 25, 2023

Conversation

abdasgupta
Copy link
Contributor
@abdasgupta abdasgupta commented May 25, 2023 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
This PR cherry picks commits from the following PRs:

  1. Fixes scaleup from single-node to multi-node etcd cluster #598
  2. [ci:component:github.com/gardener/etcd-backup-restore:v0.24.0->v0.24.1] #601

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Backup-restore waits for its etcd to be ready before attempting to update peerUrl

When scaling from single-node to multi-node etcd cluster, Etcd Druid will now first ensure that any change to the peer URL (e.g TLS enablement)  is seen by the existing etcd process running within the etcd member pod. Once that is confirmed then it will scale up the Etcd StatefulSet and add relevant annotations.

gardener-robot-ci-1 and others added 2 commits May 25, 2023 19:05
@gardener-robot-ci-1 @abdasgupta
Upgrade etcd-backup-restore
106466e 
from v0.24.0 to v0.24.1
@unmarshall @ishan16696
@seshachalam-yv @aaronfern @abdasgupta
Fixes scaleup from single-node to multi-node etcd cluster (gardener#598)
d927c89 
* scaling fix: complete TLS update before scaleup
* Add step to wait for lease to get ready and only preserve annotations when restarting pod
Co-authored-by: Aaron Francis Fernandes aaron.francis.fernandes@sap.com
Co-authored-by: Ishan Tyagi <42602577+ishan16696@users.noreply.github.com>
Co-authored-by: Seshachalam <104052572+seshachalam-yv@users.noreply.github.com>
Co-authored-by: aaronfern <aaron.francis.fernandes@sap.com>
@abdasgupta abdasgupta requested a review from a team as a code owner May 25, 2023 13:47
@gardener-robot gardener-robot added the area/control-plane Control plane related label May 25, 2023
@gardener-robot
Copy link

@abdasgupta Label kind/auto-scaling does not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 25, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
seshachalam-yv
seshachalam-yv approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor
@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 25, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2023
unmarshall
unmarshall approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor
@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abdasgupta abdasgupta merged commit 1a78d5f into gardener:hotfix-v0.18 May 25, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 25, 2023
@abdasgupta abdasgupta deleted the hotfix-v0.18 branch May 25, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

@aaronfern aaronfern aaronfern approved these changes

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abdasgupta @gardener-robot @unmarshall @aaronfern @seshachalam-yv @gardener-robot-ci-1 @gardener-robot-ci-3
0