8000 Print build version and go runtime info by shreyas-s-rao · Pull Request #636 · gardener/etcd-druid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Print build version and go runtime info #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2023
Merged

Print build version and go runtime info #636

merged 2 commits into from
Jul 11, 2023

Conversation

shreyas-s-rao
Copy link
Contributor

How to categorize this PR?

/area logging
/kind enhancement

What this PR does / why we need it:
Print build version and go runtime info when running a built version of etcd-druid.

Which issue(s) this PR fixes:
Fixes #628

Special notes for your reviewer:
/invite @acumino

Release note:

Print build version and go runtime info.

@shreyas-s-rao shreyas-s-rao added this to the v0.19.0 milestone Jul 11, 2023
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner July 11, 2023 10:46
@gardener-robot gardener-robot requested a review from acumino July 11, 2023 10:47
@gardener-robot gardener-robot added area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 11, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 11, 2023
acumino
acumino approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member
@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 11, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2023
acumino
acumino reviewed Jul 11, 2023
View reviewed changes
@shreyas-s-rao
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

1 similar comment
@aaronfern
Copy link
Contributor

/test pull-etcd-druid-e2e-kind

@aaronfern aaronfern merged commit 298551f into gardener:master Jul 11, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 11, 2023
@shreyas-s-rao shreyas-s-rao deleted the enh/print-version branch July 12, 2023 00:30
@shreyas-s-rao shreyas-s-rao mentioned this pull request Jul 12, 2023
Merged
shreyas-s-rao added a commit to shreyas-s-rao/etcd-druid that referenced this pull request Jul 12, 2023
@shreyas-s-rao
Print build version and go runtime info (gardener#636)
ed078ed 
* Print build version and go runtime info

* Fix docker build
shreyas-s-rao added a commit that referenced this pull request Jul 12, 2023
@shreyas-s-rao @acumino @unmarshall
Cherry-pick PRs for v0.18.4 (#637)
bd914c9 
* Exclude outdated client-go in `go.mod` (#627)

* Fixes for etcd status fields (#594)

* Use structured log messages (#632)

* Add CVE categorization (#634)

* Print build version and go runtime info (#636)

Co-authored-by: Shreyas Rao <42259948+shreyas-s-rao@users.noreply.github.com>
Co-authored-by: Sonu Kumar Singh <sksgkpvks@gmail.com>
Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
@shreyas-s-rao shreyas-s-rao self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino approved these changes

@aaronfern aaronfern aaronfern approved these changes

Assignees

@shreyas-s-rao shreyas-s-rao

Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.

Print version in start
7 participants
@shreyas-s-rao @aaronfern @acumino @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0