8000 Change GetAll CRD API to return a Map with keys as CRD name by unmarshall · Pull Request #1024 · gardener/etcd-druid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change GetAll CRD API to return a Map with keys as CRD name #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

Change GetAll CRD API to return a Map with keys as CRD name #1024

merged 2 commits into from
Mar 10, 2025

Conversation

unmarshall
Copy link
Contributor
@unmarshall unmarshall commented Mar 10, 2025 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
Changes the GetAll CRD API to return a map with keys being the CRD name instead of Kind.

Which issue(s) this PR fixes:
Fixes #1023

Release note:

Change the GetAll CRD API to return a map with keys having CRD names instead of Kind.

@unmarshall unmarshall requested a review from a team as a code owner March 10, 2025 11:30
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 10, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 10, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 10, 2025
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-integration

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 10, 2025
shreyas-s-rao
shreyas-s-rao approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor
@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unmarshall thanks for the PR.
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 10, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 10, 2025
@shreyas-s-rao shreyas-s-rao added this to the v0.28.0 milestone Mar 10, 2025
@unmarshall
Copy link
Contributor Author

/retest

1 similar comment
@unmarshall
Copy link
Contributor Author

/retest

@unmarshall unmarshall merged commit a019603 into gardener:master Mar 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees

@unmarshall unmarshall

Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.

Change CRD API to use CRD name as the key instead of Kind
6 participants
@unmarshall @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0