-
Notifications
You must be signed in to change notification settings - Fork 53
Reverted one change which was introduced to reduce flakiness in e2e tests. #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unmarshall
approved these changes
Mar 17, 2025
/test pull-etcd-druid-e2e-kind |
druid e2e tests passed locally twice. Logs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/testing
Testing related
kind/test
Test
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/review
Needs review
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind test
What this PR does / why we need it:
backupDeltaSnapshotPeriod
was increased to3sec
from1sec
to reduce the flakiness of druid e2e tests.With the fix of this PR: gardener/etcd-backup-restore#845, the flakiness in druid e2e tests will no longer be the case, so I'm reverting this temporary change which was introduced to fix flakiness in druid e2e tests.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc @unmarshall
Release note: