8000 [GEP-26] Add issuer field to workloadIdentity.status by vpnachev · Pull Request #11168 · gardener/gardener · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[GEP-26] Add issuer field to workloadIdentity.status #11168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[GEP-26] Add issuer field to workloadIdentity.status #11168

wants to merge 4 commits into from

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/area security ipcei
/kind enhancement
/ipcei workload-identity

What this PR does / why we need it:
Add issuer field to workloadIdentity.status

Which issue(s) this PR fixes:
Part of #9586

Special notes for your reviewer:

Release note:

@gardener-prow gardener-prow bot added area/security Security related area/ipcei IPCEI (Important Project of Common European Interest) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jan 14, 2025
@gardener-prow gardener-prow bot requested review from ary1992 and plkokanov January 14, 2025 21:34
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2025
dimityrmirchev
dimityrmirchev reviewed Jan 15, 2025
View reviewed changes
Copy link
Member
@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor suggestions, other looks good

vpnachev and others added 3 commits January 15, 2025 14:53
@vpnachev
Use pointer to string for the issuer field
9a58226
@vpnachev @dimityrmirchev
Apply review feedback
2062430 
Co-authored-by: Dimitar Mirchev <dimitar.mirchev@sap.com>
@vpnachev @dimityrmirchev
Apply review feedback 2
82f2a9d 
Co-authored-by: Dimitar Mirchev <dimitar.mirchev@sap.com>
@vpnachev vpnachev changed the title Add issuer field to workloadIdentity.status [GEP-26] Add issuer field to workloadIdentity.status Jan 15, 2025
@vpnachev vpnachev mentioned this pull request Jan 15, 2025
Open
68 tasks
@gardener-prow Gardener Prow
Copy link
Contributor
gardener-prow bot commented Jan 15, 2025 •
edited
Loading

@vpnachev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 82f2a9d link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vpnachev
Copy link
Member Author

/retest-required

dimityrmirchev
dimityrmirchev approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member
@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@gardener-prow Gardener Prow
Copy link
Contributor
gardener-prow bot commented Jan 17, 2025

LGTM label has been added.

Git tree hash: a08318fca923292a3469eb081ddbb9074c91a75b

@gardener-prow Gardener Prow
Copy link
Contributor
gardener-prow bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dimityrmirchev
Once this PR has been reviewed and has the lgtm label, please assign tobschli for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vpnachev
Copy link
Member Author

/hold to discuss internally alternative solution

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@vpnachev vpnachev mentioned this pull request Jan 26, 2025
Merged
@vpnachev
Copy link
Member Author

/close in favor of #11238

@timuthy timuthy closed this Jan 27, 2025
@vpnachev vpnachev deleted the gep26/populate-issuer-in-workload-identity-status branch January 27, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

@ary1992 ary1992 Awaiting requested review from ary1992

@plkokanov plkokanov Awaiting requested review from plkokanov

Assignees

@dimityrmirchev dimityrmirchev

Labels
area/ipcei IPCEI (Important Project of Common European Interest) area/security Security related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpnachev @dimityrmirchev @timuthy
0