8000 Tunnelcontroller for HA: Fix ip6tnl suffix to use two last bytes by MartinWeindel · Pull Request #125 · gardener/vpn2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tunnelcontroller for HA: Fix ip6tnl suffix to use two last bytes #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

Tunnelcontroller for HA: Fix ip6tnl suffix to use two last bytes #125

merged 2 commits into from
Jan 14, 2025

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
The tunnel-controller running in the vpn-shoot pods for VPN HA must create ip6 tunnel devices with unique names for each kube-apiserver. For that purpose its IPv6 address in the bonding tunnel network is used.
By mistake, only the last byte of the address was used for naming, but the IPv6 addresses are chosen randomly in the /112 subrange, i.e. the last two bytes must be considered.
Therefore, when two kube-apiserver with the same last byte have been created, there was a clash in the tunnel device name causing deletion of still needed tunnel devices and destroying the connection to these kube-apiservers.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Tunnelcontroller for HA: Fix ip6tnl suffix to use two last bytes

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 13, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 13, 2025
@MartinWeindel MartinWeindel marked this pull request as draft January 13, 2025 21:47
@MartinWeindel MartinWeindel marked this pull request as ready for review January 13, 2025 22:03
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 13, 2025
@axel7born
Copy link
Collaborator

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 14, 2025
axel7born
axel7born previously approved these changes Jan 14, 2025
View reviewed changes
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 14, 2025
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Jan 14, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 14, 2025
DockToFuture
DockToFuture approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member
@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DockToFuture DockToFuture merged commit 6d13a40 into master Jan 14, 2025
11 checks passed
@DockToFuture DockToFuture deleted the fix/ip6tnl-name branch January 14, 2025 07:34
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axel7born axel7born axel7born approved these changes

@DockToFuture DockToFuture DockToFuture approved these changes

@marwinski marwinski Awaiting requested review from marwinski marwinski is a code owner

@ScheererJ ScheererJ Awaiting requested review from ScheererJ ScheererJ is a code owner

@domdom82 domdom82 Awaiting requested review from domdom82 domdom82 is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartinWeindel @axel7born @DockToFuture @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot
0