8000 Always listen on both IPv4 and IPv6 sockets on server side. by ScheererJ · Pull Request #129 · gardener/vpn2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Always listen on both IPv4 and IPv6 sockets on server side. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

Always listen on both IPv4 and IPv6 sockets on server side. #129

merged 1 commit into from
Jan 23, 2025

Conversation

ScheererJ
Copy link
Member

What this PR does / why we need it:

Always listen on both IPv4 and IPv6 sockets on server side.

To simplify the configuration by removing unnecessary options and make it easier to support dual-stack configurations on server side with single-stack on client side, the vpn server is configured to always listen on both IPv4 as well as IPv6 sockets. Unfortunately, this is achieved via the unintuitive tcp6-server option. Looking at it via tools like netstat or ss, it looks like there is only an IPv6 socket, but you can also address it via IPv4.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Always listen on both IPv4 and IPv6 sockets on server side.

@ScheererJ
Always listen on both IPv4 and IPv6 sockets on server side.
73234f5 
To simplify the configuration by removing unnecessary options and make
it easier to support dual-stack configurations on server side with
single-stack on client side, the vpn server is configured to always
listen on both IPv4 as well as IPv6 sockets. Unfortunately, this is
achieved via the unintuitive `tcp6-server` option.
Looking at it via tools like `netstat` or `ss`, it looks like there is
only an IPv6 socket, but you can also address it via IPv4.
@ScheererJ ScheererJ requested review from DockToFuture, marwinski, axel7born, MartinWeindel and domdom82 as code owners January 23, 2025 12:40
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 23, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2025
DockToFuture
DockToFuture approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member
@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 23, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2025
@ScheererJ ScheererJ merged commit b8d7c05 into gardener:master Jan 23, 2025
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DockToFuture DockToFuture DockToFuture approved these changes

@marwinski marwinski Awaiting requested review from marwinski marwinski is a code owner

@axel7born axel7born Awaiting requested review from axel7born axel7born is a code owner

@MartinWeindel MartinWeindel Awaiting requested review from MartinWeindel MartinWeindel is a code owner

@domdom82 domdom82 Awaiting requested review from domdom82 domdom82 is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScheererJ @DockToFuture @gardener-robot-ci-2 @gardener-robot
0