feat: inclusion lists #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc885d1 to
c5dfae8
Compare
empty api basic api & IL fetching move list fetching into chain event updater better IL slot cutoff timing .gitignore local config etc lint cleanup
bfad01f to
3af26b2
Compare
gd-0
requested changes
May 21, 2025
a2c69f5 to
3923e3c
Compare
0w3n-d
approved these changes
May 27, 2025
| let slot: i32 = self.head_slot.try_into().unwrap(); | ||
| let slot_coordinate = get_slot_coordinate(slot, pub_key, parent_hash); | ||
| let (postgres_result, redis_result) = tokio::join!( | ||
| self.database.save_inclusion_list(&inclusion_list, slot), |
There was a problem hiding this comment.
Might be a good not to join on the db task here. We've seen some spikes when writing to the db lately and wouldn't want to delay the completion of this process_slot task.
There was a problem hiding this comment.
Ah, that's a fair point - we could move the error handling, etc., into the future and leave it as a tokio::spawn, so we don't await it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working V1 for relay support of inclusion lists.
/relay/v1/builder/inclusion_listwhich returns a copy of this slots relay list (if one exists)We fetch the IL as part of the housekeeper and communicate with the API through a redis pub sub channel. We also store inclusion lists in postgres so we can look back at things if needed.