Update Apply APIs to authorize Upserts against full label sets #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates both the broker and consumer Apply APIs to handle label selectors differently for Upserts and Deletes: For Upserts: - Authorization now checks against the full label set (including meta-labels) - Uses LabelSetExt() to get all labels including "name" (broker) or "id" (consumer) - Ensures consistency with how List operations authorize For Deletes: - Maintains backward compatibility with name-only (broker) or id-only (consumer) authorization - No change in behavior for delete operations This change ensures that users with label-based claims can only upsert journals/shards if their claims match all the labels on the resource, not just the name/id. This provides more granular access control. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates both the broker and consumer Apply APIs to handle label selectors differently for Upserts and Deletes:
For Upserts:
For Deletes:
This change ensures that users with label-based claims can only upsert journals/shards if their claims match all the labels on the resource, not just the name/id. This provides more granular access control.
🤖 Generated with Claude Code
This change is