8000 Enable Mongo transactions for updating model cards by GCHQDeveloper36 · Pull Request #1237 · gchq/Bailo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable Mongo transactions for updating model cards #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable Mongo transactions for updating model cards #1237

wants to merge 1 commit into from

Conversation

GCHQDeveloper36
Copy link
Member

(Depends on #1236)

Suggested implementation for transactions around updating model cards - possibly consider this WIP until there's been some further testing done by others.

@GCHQDeveloper36 GCHQDeveloper36 force-pushed the dev/use-mongo-transactions branch from f9028a4 to c556248 Compare May 3, 2024 01:41
@GCHQDeveloper36 GCHQDeveloper36 force-pushed the dev/use-mongo-transactions branch from 92d8326 to eb8721d Compare June 29, 2024 00:07
@GCHQDeveloper36 GCHQDeveloper36 marked this pull request as ready for review June 29, 2024 00:08
@GCHQDeveloper36 GCHQDeveloper36 force-pushed the dev/use-mongo-transactions branch from eb8721d to f0bc1a0 Compare July 2, 2024 21:10
@GCHQDeveloper36 GCHQDeveloper36 force-pushed the dev/use-mongo-transactions branch from af86873 to 55c97ad Compare January 20, 2025 15:01
@PE39806 PE39806 added the javascript Pull requests that update Javascript code label Feb 13, 2025
JR40159
JR40159 requested changes Apr 28, 2025
View reviewed changes
@GCHQDeveloper36 GCHQDeveloper36 force-pushed the dev/use-mongo-transactions branch from 55c97ad to 2bbc169 Compare April 30, 2025 20:41
@GCHQDeveloper36
Copy link
Member Author

I've refactored based on the latest comments/discussions, as well as added some basic tests in. I don't think there's much I can do about requiring 'knowledge' of the session within the backend service code without rewriting and introducing a heap of 'new' code to override the existing mongoose methods. But, if there's no session, it should be silently dropped and unused.

@GCHQDeveloper36 GCHQDeveloper36 requested a review from JR40159 May 2, 2025 19:56
ARADDCC002
ARADDCC002 requested changes May 12, 2025
View reviewed changes
@ARADDCC002 ARADDCC002 added enhancement New feature or request ready for review labels May 12, 2025
@GCHQDeveloper36 GCHQDeveloper36 force-pushed the dev/use-mongo-transactions branch from 4223d0d to 9988e82 Compare June 11, 2025 17:47
@GCHQDeveloper36
Copy link
Member Author

Squashed and rebased against v2.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARADDCC002 ARADDCC002 ARADDCC002 requested changes

@JR40159 JR40159 Awaiting requested review from JR40159

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request javascript Pull requests that update Javascript code ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GCHQDeveloper36 @ARADDCC002 @JR40159 @PE39806
0