8000 Rename the sessions for using all compiler versions. by Spacetown · Pull Request #555 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename the sessions for using all compiler versions. #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 25, 2022
Merged

Rename the sessions for using all compiler versions. #555

merged 13 commits into from
Mar 25, 2022

Conversation

Spacetown
Copy link
Member

Sessions are now named straight forward, the compiler version is always in braces where "all" is also a version. Following sessions are available:

* qa -> Run the quality tests.
- lint -> Run the lint (flake8 and black).
- black -> Run black, a code formatter and format checker.
- doc -> Generate the documentation.
- tests -> Run the tests with the default GCC version.
- tests_compiler(all) -> Run the tests with all GCC versions.
- tests_compiler(gcc-5) -> Run the test with a specifiv GCC version.
- tests_compiler(gcc-6) -> Run the test with a specifiv GCC version.
- tests_compiler(gcc-8) -> Run the test with a specifiv GCC version.
- tests_compiler(clang-10) -> Run the test with a specifiv GCC version.
- build_wheel -> Build a wheel.
- check_wheel -> Check the wheel, should not be used directly.
- upload_wheel -> Upload the wheel.
- docker_qa_build -> Build the docker container for the default GCC version.
- docker_qa_build_compiler(all) -> Build the docker containers vor all GCC versions.
- docker_qa_build_compiler(gcc-5) -> Build the docker container for a specific GCC version.
- docker_qa_build_compiler(gcc-6) -> Build the docker container for a specific GCC version.
- docker_qa_build_compiler(gcc-8) -> Build the docker container for a specific GCC version.
- docker_qa_build_compiler(clang-10) -> Build the docker container for a specific GCC version.
- docker_qa_run -> Run the docker container for the default GCC version.
- docker_qa_run_compiler(all) -> Run the docker container for the all GCC versions.
- docker_qa_run_compiler(gcc-5) -> Run the docker container for a specific GCC version.
- docker_qa_run_compiler(gcc-6) -> Run the docker container for a specific GCC version.
- docker_qa_run_compiler(gcc-8) -> Run the docker container for a specific GCC version.
- docker_qa_run_compiler(clang-10) -> Run the docker container for a specific GCC version.
- docker_qa -> Build and run the docker container for the default GCC version.
- docker_qa_compiler(all) -> Build and run the docker container for the all GCC versions.
- docker_qa_compiler(gcc-5) -> Build and run the docker container for a specific GCC version.
- docker_qa_compiler(gcc-6) -> Build and run the docker container for a specific GCC version.
- docker_qa_compiler(gcc-8) -> Build and run the docker container for a specific GCC version.
- docker_qa_compiler(clang-10) -> Build and run the docker container for a specific GCC version.

sessions marked with * are selected, sessions marked with - are skipped.

@Spacetown Spacetown added Type: Enhancement QA related to testing, build infrastructure, etc labels Jan 9, 2022
@Spacetown Spacetown added this to the 5.1 milestone Jan 9, 2022
@Spacetown Spacetown requested a review from latk January 9, 2022 20:44
@codecov
Copy link
codecov bot commented Jan 9, 2022 •
edited
Loading

Codecov Report

Merging #555 (4019e45) into master (f1baf77) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   95.71%   95.76%   +0.05%     
==========================================
  Files          23       23              
  Lines        3315     3331      +16     
  Branches      609      610       +1     
==========================================
+ Hits         3173     3190      +17     
  Misses         69       69              
+ Partials       73       72       -1
Flag Coverage Δ
ubuntu-18.04 94.62% <ø> (+0.05%) ⬆️
windows-2019 95.45% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/writer/cobertura.py 98.29% <0.00%> (ø)
gcovr/utils.py 91.26% <0.00%> (+0.11%) ⬆️
gcovr/configuration.py 99.66% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1baf77...4019e45. Read the comment docs.

@Spacetown
Rename the sessions for using all compiler versions.
f1a6efb 
Sessions are now named straight forward, the compiler version is always in braces where "all" is also a version.
@Spacetown
Update changelog.
d3b0f5e
@Spacetown
Shorten all names.
eaa86ca
@Spacetown
Update all references of the targets.
c48c3ee
@Spacetown Spacetown force-pushed the change_session_all_compiler branch from e720e2d to c48c3ee Compare January 19, 2022 22:11
latk
latk reviewed Jan 20, 2022
View reviewed changes
@Spacetown Spacetown requested a review from latk January 25, 2022 19:29
@Spacetown Spacetown mentioned this pull request Mar 14, 2022
Closed
@Spacetown Spacetown force-pushed the change_session_all_compiler branch from c5f516a to ca2daa7 Compare March 23, 2022 21:43
@Spacetown Spacetown force-pushed the change_session_all_compiler branch from ca2daa7 to 9ed1cfd Compare March 24, 2022 19:42
latk
latk approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minus a remaining typo

@Spacetown @latk
Apply suggestions from code review
4019e45 
Co-authored-by: Lukas Atkinson <opensource@LukasAtkinson.de>
@Spacetown Spacetown merged commit b2fb2c5 into gcovr:master Mar 25, 2022
@Spacetown Spacetown deleted the change_session_all_compiler branch March 25, 2022 19:45
D-Walther pushed a commit to D-Walther/gcovr that referenced this pull request Jun 16, 2025
@Spacetown @latk
Rename the sessions for using all compiler versions. (gcovr#555)
e4cb5ac 
Co-authored-by: Lukas Atkinson <opensource@LukasAtkinson.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

Assignees
No one assigned
Labels
QA related to testing, build infrastructure, etc Type: Enhancement
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Spacetown @latk
0