Add option to configure exclude marker #561
Conversation
|
Please can you fix the formatting errors? |
|
On it (--nox lint not catching it locally, odd). |
|
There was a error in the noxfile. Please Reba's to current master, there it's fixed. |
|
Ah, I see. I don't have them on this machine, so I kindly request them to be created elsewhere :) |
|
On Dienstag, 25. Jänner 2022 20:09:04 CET Michael Förderer wrote:
@kollix At the moment I don't want to support this because we need three options to support this.
ok, if not this moment, is there a better moment then ?
The current used postfixes are also used by gcov and lcov.
which does not exclude my feature wish and sadly does not help my use case.
From which tool are your markers?
as said, MS coverage (our code is cross platform and up till now we do coverage only
on windows, but the tool is slow, so I'm looking for a better alternative but want
to avoid the need to change thousands of existing markers)
…--
Best regards/Schöne Grüße
Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?
() ascii ribbon campaign - against html e-mail
/\ - against proprietary attachments
Frühstück, Geschenkideen, Accessoires, Kulinarisches: www.lillehus.at
|
Do you have a link to that? I find no documentation with this markers. The exclusion of a single line is possible with |
|
On Mittwoch, 26. Jänner 2022 08:27:52 CET Michael Förderer wrote:
> as said, MS coverage
Do you have a link to that? I find no documentation with this markers.
The exclusion of a single line is possible with `--exclude-line-pattern`. I've a problem with adding several options to support migration from another tool. One solution can be to use the JSON coverage files and filter them by scanning the source files. The filtered files can than be used to generate a report.
Let's forget about my wish. I now learned that the mentioned COVINFO markers are post-processed
by an internal tool, not by MS coverage itself, so we can adjust that tool on our own if needed.
Thanks.
…--
Best regards/Schöne Grüße
Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?
() ascii ribbon campaign - against html e-mail
/\ - against proprietary attachments
Frühstück, Geschenkideen, Accessoires, Kulinarisches: www.lillehus.at
|
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 23 23
Lines 3293 3294 +1
Branches 609 609
=======================================
+ Hits 3151 3152 +1
Misses 69 69
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Michael Förderer <michael.foerderer@gmx.de>
As discussed in: #557
This PR adds the ability to provide a prefix to existing EXCL_LINE/START/STOP markers to allow for projects to use differing markers as necessary among builds that do not conditionally exclude executable code. The existing pattern matching option does not allow for START/STOP markers to be modified (i.e. only provides for line marking) and thus this extends that with a new option.
Closes #557