10000 Install ninja in CI with package manager by Spacetown · Pull Request #699 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Install ninja in CI with package manager #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

Spacetown
Copy link
Member
@Spacetown Spacetown commented Dec 6, 2022

In the CI there is the following warning:

Node.js 12 actions are deprecated. For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: seanmiddleditch/gha-setup-ninja@master

There is now response for seanmiddleditch/gha-setup-ninja#15 since nearly two months. To get rid of the warning we install it now with the package manager.

…n seanmiddleditch/gha-setup-ninja@master.

There is a warning and no response to the PR from the developer. To remove this warning we install it now with the package manager.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: seanmiddleditch/gha-setup-ninja@master
@Spacetown Spacetown added QA related to testing, build infrastructure, etc Internal change Internal change not visible to user labels Dec 6, 2022
@Spacetown Spacetown added this to the Upcoming release milestone Dec 6, 2022
@codecov
Copy link
codecov bot commented Dec 6, 2022

Codecov Report

Base: 94.39% // Head: 95.48% // Increases project coverage by +1.08% 🎉

Coverage data is based on head (c97798f) compared to base (451b176).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
+ Coverage   94.39%   95.48%   +1.08%     
==========================================
  Files          27       27              
  Lines        3498     3500       +2     
  Branches      605      605              
==========================================
+ Hits         3302     3342      +40     
+ Misses        125       90      -35     
+ Partials       71       68       -3     
Flag Coverage Δ
ubuntu-20.04 94.39% <ø> (ø)
windows-2019 95.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/workers.py 98.82% <0.00%> (+0.02%) ⬆️
gcovr/writer/html.py 95.60% <0.00%> (+0.58%) ⬆️
gcovr/tests/test_gcovr.py 97.64% <0.00%> (+6.47%) ⬆️
gcovr/utils.py 91.21% <0.00%> (+7.80%) ⬆️
gcovr/tests/test_html_generator.py 100.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Spacetown Spacetown marked this pull request as ready for review December 6, 2022 19:27
@Spacetown Spacetown merged commit bfa2f45 into gcovr:master Dec 6, 2022
@Spacetown Spacetown deleted the change_installation_of_ninja branch December 6, 2022 19:27
D-Walther pushed a commit to D-Walther/gcovr that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal change Internal change not visible to user QA related to testing, build infrastructure, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0