8000 Fix reading config files by Spacetown · Pull Request #816 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix reading config files #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Conversation

Spacetown
Copy link
Member

Optional choices where treated as boolean value even if there where choices defined.

Closes #809.

@Spacetown Spacetown added Type: Bug cli relating to the command line interface or the config system labels Jul 31, 2023
@Spacetown Spacetown added this to the Upcoming release milestone Jul 31, 2023
@codecov
Copy link
codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (c5a304c) 95.59% compared to head (cbc2e15) 95.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   95.59%   95.61%   +0.02%     
==========================================
  Files          40       40              
  Lines        4041     4041              
  Branches      793      793              
==========================================
+ Hits         3863     3864       +1     
+ Misses        101      100       -1     
  Partials       77       77              
Files Changed Coverage Δ
gcovr/configuration.py 99.50% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spacetown Spacetown merged commit b7858fc into gcovr:master Aug 2, 2023
@Spacetown Spacetown deleted the fix_reading_config_files branch August 2, 2023 20:50
@Spacetown Spacetown removed this from the Upcoming release milestone Jan 26, 2024
vlc-mirrorer pushed a commit to videolan/dav1d that referenced this pull request Feb 23, 2024
gcovr 7.0 fixed a config file parsing bug [0].
Valid options are 'all', 'negative_hits.warn',
'negative_hits.warn_once_per_file'.

[0] gcovr/gcovr#816
D-Walther pushed a commit to D-Walther/gcovr that referenced this pull request Jun 16, 2025
If a const and a choice is defined for an option the validation of the choice was skipped and the value was converted to a boolean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli relating to the command line interface or the config system Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized gcov output, exceptions during parsing.
1 participant
0