8000 Update html.rst to add --html-theme github.* screenshots by mfont-bz17 · Pull Request #818 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update html.rst to add --html-theme github.* screenshots #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 19, 2023

Conversation

mfont-bz17
Copy link
Contributor

I 've added some screenshots of github themes directly in documentation html.rst but maybe a new child could be added

Output Formats
HTML Output
Themes

What do you think?

@Spacetown
Copy link
Member

I suggest to use the same file as for the default theme because it's smaller and you can see the differences better. Can you also inject the obfuscated date/time?

@Spacetown Spacetown added this to the Upcoming release milestone Aug 4, 2023
@Spacetown Spacetown added Format: HTML Docs related to the documentation or website labels Aug 4, 2023
@codecov
Copy link
codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (87634c1) 95.64% compared to head (30284c5) 95.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #818   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          41       41           
  Lines        4089     4089           
  Branches      807      807           
=======================================
  Hits         3911     3911           
  Misses        100      100           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfont-bz17 mfont-bz17 marked this pull request as ready for review August 8, 2023 08:41
Copy link
Member
@Spacetown Spacetown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only thing I see now is that the boxes in the right upper corner should have a fixed size since the width depends on the needed digits of the value (100.0% is bigger). Do you want to fix it together with this PR or in a separate PR?

@mfont-bz17
Copy link
Contributor Author

Now the width is fixed using wrapper and the background depends on the digits, in all places.

header
imatge

list
imatge

I created some examples with fixed width label. If 100.0% not appears we have always an extra

header
imatge
imatge
imatge

list
imatge

In the list part I prefer keep as now, in the header part maybe can be changed, I'm not sure what is better....

@Spacetown
Copy link
Member

I created some examples with fixed width label. If 100.0% not appears we have always an extra

header imatge imatge imatge

list imatge

In the list part I prefer keep as now, in the header part maybe can be changed, I'm not sure what is better....

I prefer this since it looks calmer.

@mfont-bz17
Copy link
Contributor Author

Pushed with the fixed size

Copy link
Member
@Spacetown Spacetown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@Spacetown Spacetown merged commit a6ee1af into gcovr:master Aug 19, 2023
@Spacetown Spacetown removed this from the Upcoming release milestone Jan 26, 2024
D-Walther pushed a commit to D-Walther/gcovr that referenced this pull request Jun 16, 2025
* Fix size of label of coverage percentange
* Update github themes doc image with new style
* Update test reference html-themes-github

---------

Co-authored-by: Michael Förderer <michael.foerderer@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs related to the documentation or website Format: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0