-
Notifications
You must be signed in to change notification settings - Fork 285
Update html.rst to add --html-theme github.* screenshots #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update html.rst to add --html-theme github.* screenshots #818
Conversation
I suggest to use the same file as for the default theme because it's smaller and you can see the differences better. Can you also inject the obfuscated date/time? |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 41 41
Lines 4089 4089
Branches 807 807
=======================================
Hits 3911 3911
Misses 100 100
Partials 78 78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The only thing I see now is that the boxes in the right upper corner should have a fixed size since the width depends on the needed digits of the value (100.0%
is bigger). Do you want to fix it together with this PR or in a separate PR?
Now the width is fixed using wrapper and the background depends on the digits, in all places. I created some examples with fixed width label. If 100.0% not appears we have always an extra In the list part I prefer keep as now, in the header part maybe can be changed, I'm not sure what is better.... |
Pushed with the fixed size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
* Fix size of label of coverage percentange * Update github themes doc image with new style * Update test reference html-themes-github --------- Co-authored-by: Michael Förderer <michael.foerderer@gmx.de>
I 've added some screenshots of github themes directly in documentation html.rst but maybe a new child could be added
Output Formats
HTML Output
Themes
What do you think?