8000 Add file version check for external files by Spacetown · Pull Request #999 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add file version check for external files #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Spacetown
Copy link
Member

This PR adds a check for the format version mentioned inside the gcov JSON file.

Closes #995

Copy link
@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 75.00% (target: 60.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1814a34) 4231 4138 97.80%
Head commit (5884f6b) 4234 (+3) 4140 (+2) 97.78% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#999) 4 3 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Spacetown Spacetown merged commit 4cff3ee into gcovr:main Oct 14, 2024
33 checks passed
@Spacetown Spacetown deleted the add_file_version_check_for_external_files branch October 14, 2024 21:05
D-Walther pushed a commit to D-Walther/gcovr that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'block_ids'
2 participants
0