numberedbookmarks: fix Ctrl+num and Ctrl+Shift+num on various keyboard layouts #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d layouts Inside plugin_init(), the current version precomputes key values for number keys after pressing shift (on US keyboard, ! for 1, @, for 2, etc.) and uses these values for detecting key presses. However, it makes some assumptions that are not quite correct for all keyboard layouts: 1. It assumes that keyboard layout cannot change and precomputes key values once on plugin init. It is quite common to change keyboard layout while using an editor and the precomputed values aren't correct in this case. 2. It assumes that numbers are typed directly for all keyboard layouts without pressing shift. This is incorrect e.g. for the Czech keyboard where numbers are typed by Shift plus a key from the top row. In this case the current code doesn't precompute Shift+key values correctly 3. By assuming that numbers are typed without shift, it detects Ctrl+numkey incorrectly on keyboard layouts requiring shift. This patch fixes these issues in the following way: 1. It moves key precomputation outside plugin_init() and performs it every time Ctrl+key or Ctrl+Shift+key is pressed. 2. It stores precomputed numeric key values both for Shift+key and NonShift+key variants. Since the Shift key gets consumed by GTK and we can't be sure whether it was pressed or not, we can use these two groups and based on key presence in one of them we can determine whether Shift was pressed or not and perform the corresponding action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside
plugin_init(), the current version precomputes key values for number keys after pressing shift (on US keyboard,!for1,@, for2, etc.) and uses these values for detecting key presses. However, it makes some assumptions that are not quite correct for all keyboard layouts:This patch fixes these issues in the following way:
plugin_init()and performs it every time Ctrl+key or Ctrl+Shift+key is pressed.