Add compatibility for AmazonLinux. #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible identifies AmazonLinux as: ansible_os_family: "RedHat" ansible_distribution_major_version == "NA" But it is seemingly otherwise indistinguishable from RedHat / CentOS. This sets the correct variables for packages, services, etc, which differ from RHEL / CentOS.
|
Also, AmazonLinux has both Apache2.2 and Apache2.4 under different package names. I am not really sure on how to include this. |
geerlingguy
reviewed
Apr 3, 2017
tasks/main.yml
Outdated
| @@ -3,6 +3,11 @@ | |||
| - name: Include OS-specific variables. | |||
| include_vars: "{{ ansible_os_family }}.yml" | |||
|
|
|||
| # If AmazonLinuxm include needed variables. | |||
| - name: Include OS-specific variables. | |||
There was a problem hiding this comment.
Maybe delete the comment above this line, and set name: Include variables for Amazon Linux.
geerlingguy
reviewed
Apr 3, 2017
| apache_vhosts_version: "2.4" | ||
|
|
||
| __apache_packages: | ||
| - httpd24 |
There was a problem hiding this comment.
I'd say (regarding your question in the PR summary) it's fine to default to 2.4, and then users could (if they wanted) override by setting apache_packages in their own playbook vars later.
geerlingguy
added a commit
that referenced
this pull request
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible identifies AmazonLinux as:
ansible_os_family: "RedHat"
ansible_distribution_major_version == "NA"
But it is seemingly otherwise indistinguishable from RedHat / CentOS.
This sets the correct variables for packages, services, etc, which
differ from RHEL / CentOS.