8000 Un-stall PR on General Elastic Metric by ninamiolane · Pull Request #1182 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Un-stall PR on General Elastic Metric #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 22, 2021
Merged

Un-stall PR on General Elastic Metric #1182

merged 8 commits into from
Oct 22, 2021

Conversation

ninamiolane
Copy link
Collaborator

This aims to merge @Florent-Michel 's PR #1078 .

@codecov
Copy link
codecov bot commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #1182 (49855f9) into master (3b75a44) will decrease coverage by 0.07%.
The diff coverage is 90.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
- Coverage   94.50%   94.43%   -0.06%     
==========================================
  Files          89       89              
  Lines        8895     8989      +94     
==========================================
+ Hits         8405     8488      +83     
- Misses        490      501      +11
Flag Coverage Δ
autograd 93.87% <89.80%> (-0.05%) ⬇️
numpy 91.44% <89.80%> (-0.02%) ⬇️
pytorch 84.67% <68.63%> (-0.88%) ⬇️
tensorflow 81.24% <89.80%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/discrete_curves.py 93.57% <89.48%> (-1.00%) ⬇️
geomstats/_backend/pytorch/linalg.py 97.96% <100.00%> (-2.04%) ⬇️
geomstats/datasets/utils.py 100.00% <100.00%> (ø)
geomstats/geometry/spd_matrices.py 99.61% <100.00%> (ø)
geomstats/learning/expectation_maximization.py 87.23% <0.00%> (-0.55%) ⬇️
geomstats/learning/kmeans.py 87.50% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6c95f...49855f9. Read the comment docs.

@ninamiolane ninamiolane merged commit 7ac86c8 into geomstats:master Oct 22, 2021
@ninamiolane ninamiolane deleted the florent-pr branch October 22, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninamiolane @Florent-Michel
0