8000 Add check in SRVMetric by alebrigant · Pull Request #1496 · geomstats/geomstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add check in SRVMetric #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add check in SRVMetric #1496

wants to merge 1 commit into from

Conversation

alebrigant
Copy link
Collaborator

This PR adresses issue #1283.

Before computing the srv transform of a discrete curve, check that consecutive sample points are distinct are raise an error if not.

@codecov
Copy link
codecov bot commented Apr 14, 2022 •
edited
Loading

Codecov Report

Merging #1496 (c91f0a7) into master (1864374) will decrease coverage by 0.32%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   92.84%   92.53%   -0.31%     
==========================================
  Files         100       92       -8     
  Lines       10398     9200    -1198     
==========================================
- Hits         9653     8512    -1141     
+ Misses        745      688      -57
Flag Coverage Δ
autograd 92.40% <75.00%> (+0.01%) ⬆️
numpy 89.97% <75.00%> (+0.01%) ⬆️
pytorch ?
tensorflow ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/discrete_curves.py 91.62% <75.00%> (-0.14%) ⬇️
geomstats/tests.py 72.89% <0.00%> (-22.03%) ⬇️
geomstats/errors.py 88.89% <0.00%> (-11.11%) ⬇️
geomstats/_backend/__init__.py 77.78% <0.00%> (-6.34%) ⬇️
geomstats/learning/geodesic_regression.py 87.67% <0.00%> (-1.94%) ⬇️
geomstats/geometry/grassmannian.py 94.69% <0.00%> (-1.06%) ⬇️
geomstats/geometry/special_euclidean.py 88.89% <0.00%> (-0.24%) ⬇️
geomstats/visualization.py 90.16% <0.00%> (-0.14%) ⬇️
geomstats/_backend/tensorflow/random.py
geomstats/_backend/pytorch/__init__.py
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1864374...c91f0a7. Read the comment docs.

@alebrigant
Copy link
Collaborator Author

@ninamiolane the curves in the notebook on cell shapes analysis need to be "pre processed" to remove duplicate consecutive points. Can you take a look ?

@ninamiolane
Copy link
Collaborator

@alebrigant yes! we will take over this PR from now on. Many thanks!

@ninamiolane ninamiolane marked this pull request as draft April 14, 2022 14:23
@ninamiolane
Copy link
Collaborator

This has been solved by #1525

@alebrigant alebrigant deleted the alebrigant-curves branch January 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alebrigant @ninamiolane
0